Re: [PATCH] Add a gitlab-ci stage to test for tabs in C source code.

On Wed, Feb 11, 2026 at 05:10:35PM +0100, Rene Kita wrote:
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index d2416d1d..6aa14130 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -2,6 +2,7 @@ image: registry.gitlab.com/muttmua/mutt/ubuntu:18.04
>
>Does GitLab or Ubuntu has some sort of latest stable tag? 18.04 is quite
>old.

I noticed how old it was as I was making this change.  I'll update it to 
a newer release.

The last time I did that was 2018, and at the time I remember I had to 
grab a docker image, add in all the mutt build dependencies, generate a 
new image and then upload it to the gitlab registry.  I had/have little 
experience working with docker, so I've avoided it doing it again ;-).

If there is another way, similar to with the sr.ht ".build/" directory 
files I'd love to hear about it.  So people with gitlab experience 
please feel free to share!

>> +tabcheck:
>> +  stage: tabcheck
>> +  script:
>> +    - find . -name '*.[ch]' -print0 | xargs -0 perl -n -e '/\t/ && die "tab found in $ARGV"'
>I usually limit this to pushed changes, but as long as it works: OK.

I'll push it for now then.  Suggestions and patches are most welcome. 
I'm also not that familiar with CI systems, so I'm sure the file could 
be done better.

>I also would prefer a make target for such things, but I also prefer to
>not deal with automake. ;-)

Noted.  I'll see if I can add something.  I personally maintain my own 
checker script that runs check_sec.sh; cd doc && make validate; and then 
a custom script I have to double check op and function overloading.

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEiXWpszqjeRA4XFMIre92hIAxa9oFAmmNQ2EACgkQre92hIAx
a9o5IxAAzddOjM05NrN9PmRAwYnCpYvWYmH/W1+SRdbpTELgphg70WfAqskOc9wA
uDpG5n0OlCt1+8qIvdc6yPgxFJheHiKXvoi2mGJjiNotQljVnPZYJlNkEalTI9h/
NROohxpEJKtICPnm60wfZQMUN4J/eUNO2BsqeSN9tMI5slyxs3fyAw5TtRR2PaR0
3+WmvnXJmValWqt11XcacMluQVFckMLh+9pEh5hbdPaPTmdLgE8MvJJOdkoygGAP
8fKOE2IEhQ01IHS+A/HNlQRfjDv4bAtcOG0hAVtXcf8sTO4Er48Oc8QryVejls3Q
tCyptSeu+mc/NAv9UmweU7SPh4ST/WVm50e+HjZjEp2tGAopGOijQmak5mgD9Y0F
w8InaRpz8g7LK+QWqyW6zxzJEIOSl22CvfXf/shg7JAdP4QOlwyb07mAeA7Dr8/5
C6EUo0+fVRPIBoq05EHXcozd6SxjfzMsZyne+u9nqAEvgBQCfFw+wH0NoBGmc3Gd
gawvTUkVDcMmoEgk/UPsDt0x5I3pcL4/jlH4OwW3mOvuJ02FdjiWLZ5z/uS/TsIx
AcUJS2BOjIqvPct4FqUJCsj2tp7KFu+HAcMUx7/Rarlb8Bn4R1Wicqqa/GB5k95+
sgDiIqS+9KVyCeQ6wacsqOrydA85QArRuOa119/ETK2yZQp8i4k=
=R5U5
-----END PGP SIGNATURE-----