Re: [PATCH] Add a gitlab-ci stage to test for tabs in C source code.

On Thu, Feb 12, 2026 at 11:05:05AM +0800, Kevin J. McCarthy wrote:
> On Wed, Feb 11, 2026 at 05:10:35PM +0100, Rene Kita wrote:
> > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > index d2416d1d..6aa14130 100644
> > > --- a/.gitlab-ci.yml
> > > +++ b/.gitlab-ci.yml
> > > @@ -2,6 +2,7 @@ image: registry.gitlab.com/muttmua/mutt/ubuntu:18.04
> > 
> > Does GitLab or Ubuntu has some sort of latest stable tag? 18.04 is quite
> > old.
> 
> I noticed how old it was as I was making this change.  I'll update it to a
> newer release.
> 
> The last time I did that was 2018, and at the time I remember I had to grab
> a docker image, add in all the mutt build dependencies, generate a new image
> and then upload it to the gitlab registry.  I had/have little experience
> working with docker, so I've avoided it doing it again ;-).
> 
> If there is another way, similar to with the sr.ht ".build/" directory files
> I'd love to hear about it.  So people with gitlab experience please feel
> free to share!

All this is not urgent. I can have a look how to update the GitLab
Ubuntu, if you prefer. Haven't used GitLab since 2019 though.

> > > +tabcheck:
> > > +  stage: tabcheck
> > > +  script:
> > > +    - find . -name '*.[ch]' -print0 | xargs -0 perl -n -e '/\t/ && die "tab found in $ARGV"'
> > I usually limit this to pushed changes, but as long as it works: OK.
> 
> I'll push it for now then.  Suggestions and patches are most welcome. I'm
> also not that familiar with CI systems, so I'm sure the file could be done
> better.
> 
> > I also would prefer a make target for such things, but I also prefer to
> > not deal with automake. ;-)
> 
> Noted.  I'll see if I can add something.  I personally maintain my own
> checker script that runs check_sec.sh; cd doc && make validate; and then a
> custom script I have to double check op and function overloading.

I think you wrote about this somewhere about doing releases. Let's see
if we can collect this in some script and just add a make target to call
that script. But, again, low priority.