Re: [PATCH] Drop -pedantic from CFLAGS

"Kevin J. McCarthy" <[email protected]> Fri, 13 Feb 2026 17:57:28 +0800

Newsgroups	gmane.mail.mutt.devel
Message-ID	<aY71iGygrNn0a1ez@qinghai>

On Fri, Feb 13, 2026 at 09:27:43AM +0100, Rene Kita wrote:
>Consensus is that it does more harm than good.
>---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Whoops, I apologize.  I didn't express myself clearly.  At the time I 
thought we were talking about disabling it in the sr.ht CI builds that 
were causing you to contort to get working with -Werror also enabled.

While I'm not absolutely against removing -pedantic, my limited 
understanding was that "-Wall -pedantic" was a pretty good combination 
to ensure code is more compatible with other compilers and environments.

I'd like to hear other opinions before we completely drop it from our 
default compiler options.

>diff --git a/configure.ac b/configure.ac
>index 33d483d2..927f0243 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -956,7 +956,7 @@ AC_ARG_ENABLE(warnings, AS_HELP_STRING([--disable-warnings],[Turn off compiler w
> fi])
>
> if test $mutt_cv_warnings = yes; then
>-  CFLAGS="-Wall -pedantic $CFLAGS"
>+  CFLAGS="-Wall $CFLAGS"
> fi
>
> AC_ARG_ENABLE(nfs-fix, AS_HELP_STRING([--enable-nfs-fix],[Work around an NFS with broken attributes caching]),
>-- 
>2.51.0
>

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

signature.asc (application/pgp-signature, 833 B)