Re: [PATCH] Set up 'make check' and add tab scanner.

"Kevin J. McCarthy" <[email protected]> Mon, 16 Feb 2026 17:25:52 +0800

Newsgroups	gmane.mail.mutt.devel
Message-ID	<aZLioG4WtekPLrtF@qinghai>

On Mon, Feb 16, 2026 at 09:12:54AM +0100, Rene Kita wrote:
>Do you mean that 'unimportant issues' which got suppressed with this
>--exclude? I.e. we should be able to run shellcheck without the
>--exclude?

No, I get the following output when I run it on my (Arch) laptop, most 
of which don't seem to be things that are important to change:

$ make shellcheck
  cd . && /bin/sh /home/kjm/data/stow/home/dev/mutt/git/mutt/missing automake-1.18 --foreign Makefile
  cd . && /bin/sh ./config.status Makefile depfiles
config.status: creating Makefile
config.status: executing depfiles commands
(find . -name \*.sh && echo "gen_defs muttbug prepare") | xargs shellcheck --exclude=SC2003,SC2006,SC2086,SC2162,SC2046

In ./pre-commit.sh line 8:
cd $MUTTDIR
^---------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

Did you mean:
cd $MUTTDIR || exit

In ./pre-commit.sh line 12:
   xargs -0 perl -n -e '/\t/ && die "tab found in $ARGV"'
                       ^-- SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.

In ./contrib/bgedit-screen-tmux.sh line 55:
if test x$STY != x; then
         ^---^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose.

Did you mean:
if test $STY != ""; then

In ./contrib/bgedit-screen-tmux.sh line 57:
elif test x$TMUX != x; then
           ^----^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose.

Did you mean:
elif test $TMUX != ""; then

In ./version.sh line 18:
[ x = "x$distance" ] && exec cat VERSION
   ^-- SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose.

Did you mean:
[ "" = "$distance" ] && exec cat VERSION

For more information:
   https://www.shellcheck.net/wiki/SC2164 -- Use 'cd ... || exit' or 'cd ... |...
   https://www.shellcheck.net/wiki/SC2016 -- Expressions don't expand in singl...
   https://www.shellcheck.net/wiki/SC2268 -- Avoid x-prefix in comparisons as ...

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

signature.asc (application/pgp-signature, 833 B)