Re: [PATCH] wip: change ISSPACE to use ascii whitespace check.

Ian Collier via Mutt-dev <[email protected]>
Newsgroups gmane.mail.mutt.devel
Message-ID <[email protected]>
On Thu, Feb 19, 2026 at 12:51:57PM +0100, Alejandro Colomar via Mutt-dev wrote:
> An inline function with that would be an alternative.  A macro is more
> compact, though, and can be implemented as a one-liner.  When
> implementing several of these, it can help readability of the entire set
> of APIs if they fit in a compact space and they are very similar:

But in your implementation of this you've already pre-defined a macro
(streq) - why not predefine a macro or inline function called, say,
is_member, to do the work and then your macros for each indivdual case
can be trivial as well as more readable.

> The strchrnul(3) version seems to have significantly less instructions.
 
I see.  But the point is moot if strchrnul is not implemented on the
system.  In addition I think the intent is slightly less clear, but
maybe that's just me.

imc
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.