Re: [PATCH 6/8] Drop --exclude from shellcheck target

On 2026-02-24T14:10:37+0100, Rene Kita wrote:
> Exceptions are now dealt with on a case-by-case basis. Drop global
> exceptions.
> ---
>  Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 4a23e16c..83fc4757 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -221,7 +221,7 @@ update-doc:
>  	(cd doc && $(MAKE) update-doc)
>  
>  shellcheck:
> -	(find . -name \*.sh && echo "gen_defs muttbug prepare") | xargs shellcheck --exclude=SC2003,SC2006,SC2086,SC2162,SC2046
> +	(find . -name \*.sh && echo "gen_defs muttbug prepare") | xargs shellcheck

Ahhh, these exceptions make sense.  So, I think I'd prefer having some
global exceptions.  We want to keep using x$foo everywhere, right?


Cheers,
Alex

>  
>  tabcheck:
>  	find . -name '*.[ch]' ! -name keymap_defs.h ! -name conststrings.c -print0 | \
> -- 
> 2.51.0
> 

-- 
<https://www.alejandro-colomar.es>

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEES7Jt9u9GbmlWADAi64mZXMKQwqkFAmmdp88ACgkQ64mZXMKQ
wqka9w//UtcWV24gtqYUH785rAcZAP7zIcnK2mufCwp47hOs2oHPyW9e+MvCVXzj
qzKZNLPxQsRWAveKaBFcs6EQP1NxhIq5DjGp37SWSlmtcEGx62kxqz8O6JEW1quo
8AzRHNc+viofIhReFZ5tU/E2FiVFe3CqtkyXkdKZVns1DBtMX+Jm52vOOpFnqD9+
YQcAFlnTcCw/RKTO67KG6lw2yF5TyhcFZayYKIbvxBAK3GGdN/fGfPJxuuFb0PUP
jU+dr/Nz28ICSSpPesvOgatiWcBMQJD0rR92ojyixWu5RMUuLVjfAUd8REdjYuEa
Kt0xjosayjl+W9K5mDKP3vH7kiVKypn7ceXIpULEO3UaWD9XRDH5xiMUnds7KlXX
fezCs/BAPTGkAJpUnIEs06yPDCAZhE3IFdc91HRXNEbcPQfolhafRWMZakbljgB7
0pMz5lSYZu3vQjhS13gJiOxYONjMbulpBWl+sIsL2TswuN6qC7v5R3/sZ+a0PlUb
FP4AthHoJxGdwBXIBpPd8rX/ZX/z9lpGrYYsF6W0H+BtzAPKJ5lM+XkibfpSKull
vg0WcYiQBGqdtwMkqhcdl60ZDViWa4OAYz1pafCywNJ3FTZMJHx6GXRpe+TY/H+H
QXxo2eRD63giy7kB3BO5mbCVMEbY+gd6Cuz1/u7EUfhyccZrhxY=
=dj0d
-----END PGP SIGNATURE-----