Re: [PATCH v2 3/8] Always double-quote parameter expansions in shell

On Wed, Feb 25, 2026 at 01:39:38PM +0100, Oswald Buddenhagen via Mutt-dev wrote:
> On Wed, Feb 25, 2026 at 11:53:25AM +0100, Rene Kita wrote:
> > +test -d "$LIBICONV"/libcharset/tools || {
> > 
> imo, these constructs look really unnatural and noisy. why not just quote
> the entire string ("word" in shell terms)?

I usually do not quote the entire word as this style also makes use of
{} delimiters for shell variables unnecessary (which is not needed here,
of course, because of the slash).

> > +for f in "$LIBICONV"/libcharset/tools/* ; do
> > 
> here it gets a bit fuzzy. i'd probably quote right up to the asterisk, but i
> have no strong preference.