Re: [PATCH 4/4] Modify compose temp files to use $tmpdraftdir functions.

On Wed, Mar 11, 2026 at 10:57:45AM +0100, Oswald Buddenhagen via Mutt-dev wrote:
>On Wed, Mar 11, 2026 at 02:59:26PM +0800, Kevin J. McCarthy wrote:
>>Handle the most common cases:
>> - compose and compose with $edit_headers
>> - postponed messages
>> - resend-message
>> - -H draft files via command line argument
>> - -i include body files via command line argument.
>>
>it's illogical to split this from patch 3, as that already updates the 
>documentation.

Maybe.  I was trying to keep the ideas behind the changes separate for 
simplicity of review.

>>There are some other cases that are borderline where tempfiles should
>>go, but it's not easy to untangle when the code is shared between
>>multiple use-cases.
>>
>i think it would be worthwhile to elaborate on these cases here.

I was looking at things such as <get-attachment> or making a message 
attachment.

However, thank you for asking.  Now that I took a second look, I 
realized I had missed other operations from the attachment menu, mostly 
in recvcmd.c, that also pass a tempfile in!

Let me make those changes and test and I'll send another version of the 
patchset.

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEiXWpszqjeRA4XFMIre92hIAxa9oFAmmxQ2YACgkQre92hIAx
a9oPvg//TEt7vjIYlLP3W2wgphJy7lJP1IDOxq7Atb2XLS1I5NjKP/3kEcl1Xxi1
PeuUvWLwndfvTQVWDll757Wn29s0OZrNWGrynMELFjs38HdaKKawrC626HwAgBsG
g2Zfuy591MEypNRBALrtXpjlARpCC1BkBYIcJW8YAchl7G9Nhwfw9maKjNnQKFaR
bUBquaYrgAJjUdql95NldDMBEkQufGiGbeXaCdv7mi5z6JyCS8fowyd7MMsvuZwn
ReYAt3MpO8WZK1J9nPXPKxwLHtHnez53EwcofyatNpN+7PdWnc8V6rSc9rfWLJHB
BWvSZVNltRBtH3PnD9TObeo/y3nINbkNvnuvOxVMvurPeWrvoNZn7LZ678Vo5RL0
rtSQTXqFUidDLByIUBvp5cNddWXpcBPRh9ddw8/oz/VMWC74XVe//5CwAjFawakw
adLv2kwPzSYeu/rvZJBH1cw8Wd9cc2+SZHbSj8OiRymyzrB13M8FkZS3v4qLCyju
7lca+aHq/LV4MrPI+giY90ejc25+VtYNA44wq8W0CIneQ4qG+6+3AZ/IVsFIooNq
9EpXfOWTy8hYE0XuniiJnYSxQhSKbqB4oqSx3MSRFWDUL+mxj8XGcyAVkq2sq5ND
oxJM3/G3G4dOs20/NjrVZdSBwZp8sWuYHZBYSMvmRqzDi+3adaE=
=wthu
-----END PGP SIGNATURE-----