Re: [PATCH 0/6] Change classic pgp to perform built-in textmode conversion

On Wed, Mar 18, 2026 at 10:50:34AM +0800, Kevin J. McCarthy wrote:
> This addresses ticket #386.
>
> Currently Mutt relies on gpg to perform conversion to and from CRLF,
> via the --textmode parameter passed to various commands.
>
> While there is nothing wrong with this, the parameter is marked as
> "legacy" in the gpg man page, and not all tools support it.
>
> To avoid possible portability issues in the future, change mutt to
> perform its own conversion. (Note however, that there is more to the story
> than just swapping tools.  Verifying signing and decryption currently
> requires carefully parsing the gpg output to check for spoofing.)
>
> Note: I've again broken this patch into bite-size chunks, for what I
> hope is easier review.  I'll be happy to squash to a single commit
> afterwards if this upsets anyone.

Builds fine here and from a quick look, LGTM!

Re commits, this might be a bit too much fine-grained, but I'm OK with
it. As long as every commit compiles I prefer 'too many commits' over
'too big commits'.

Let me take that chance to promote a great talk about how to write
proper commits:
Writing Commits For You, Your Friends, And Your Future Self - Victoria Dye
https://www.youtube.com/watch?v=4qLtKx9S9a8