Re: [PATCH 1/2] Formatting update: pointer types * placement.

Rene Kita <[email protected]>
Newsgroups gmane.mail.mutt.devel
Message-ID <[email protected]>
On Sun, Mar 29, 2026 at 02:14:49PM +0800, Kevin J. McCarthy wrote:
> Make the asterix more consistently be next to the variable.  That is,
> change "int* foo" to "int *foo".
> 
> This was done by a script that looked for basic C types (int, short,
> char, float, etc) along with struct, xxx_t, and all caps words,
> immediately followed by one or more "*", whitespace, and a word.
> 
> So, there is a chance it missed a few cases, but seems to have gotten
> them all.

Found with "grep '[A-Za-z]\* ' **/*.[ch]", the rest LGTM.

I skimmed PATCH 2/2, but this is too much to review. Just apply it.

-- >8 --

From 6f2a9af447a2db5551e7882063c8881d4ca6443e Mon Sep 17 00:00:00 2001
From: Rene Kita <[email protected]>
Date: Sun, 29 Mar 2026 09:59:59 +0200
Subject: [PATCH] fixup! Formatting update: pointer types * placement.

---
 mutt_ssl.c   |  2 +-
 mutt_zstrm.c | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/mutt_ssl.c b/mutt_ssl.c
index 14b9fa6e..192f28ce 100644
--- a/mutt_ssl.c
+++ b/mutt_ssl.c
@@ -540,7 +540,7 @@ static int ssl_socket_open (CONNECTION * conn)
 
 /* ssl_negotiate: After SSL state has been initialized, attempt to negotiate
  *   SSL over the wire, including certificate checks. */
-static int ssl_negotiate (CONNECTION *conn, sslsockdata* ssldata)
+static int ssl_negotiate (CONNECTION *conn, sslsockdata *ssldata)
 {
   int err;
   const char *errmsg;
diff --git a/mutt_zstrm.c b/mutt_zstrm.c
index 9f45eb8a..4feec966 100644
--- a/mutt_zstrm.c
+++ b/mutt_zstrm.c
@@ -63,7 +63,7 @@ static int mutt_zstrm_open (CONNECTION *conn)
 
 static int mutt_zstrm_close (CONNECTION *conn)
 {
-  zstrmctx* zctx = conn->sockdata;
+  zstrmctx *zctx = conn->sockdata;
   int rc = zctx->next_conn.conn_close (&zctx->next_conn);
 
   muttdbg(4, "zstrm_close: read %llu->%llu (%.1fx) "
@@ -91,7 +91,7 @@ static int mutt_zstrm_close (CONNECTION *conn)
 
 static int mutt_zstrm_read (CONNECTION *conn, char *buf, size_t len)
 {
-  zstrmctx* zctx = conn->sockdata;
+  zstrmctx *zctx = conn->sockdata;
   int rc = 0;
   int zrc;
 
@@ -169,7 +169,7 @@ retry:
 
 static int mutt_zstrm_poll (CONNECTION *conn, time_t wait_secs)
 {
-  zstrmctx* zctx = conn->sockdata;
+  zstrmctx *zctx = conn->sockdata;
 
   muttdbg(4, "zstrm_poll: %s",
           zctx->read.z.avail_out == 0 || zctx->read.pos > 0 ?
@@ -182,7 +182,7 @@ static int mutt_zstrm_poll (CONNECTION *conn, time_t wait_secs)
 
 static int mutt_zstrm_write (CONNECTION *conn, const char *buf, size_t count)
 {
-  zstrmctx* zctx = conn->sockdata;
+  zstrmctx *zctx = conn->sockdata;
   int rc;
   int zrc;
   char *wbufp;
@@ -237,7 +237,7 @@ static int mutt_zstrm_write (CONNECTION *conn, const char *buf, size_t count)
 
 void mutt_zstrm_wrap_conn (CONNECTION *conn)
 {
-  zstrmctx* zctx;
+  zstrmctx *zctx;
 
   zctx = (zstrmctx*) safe_calloc (1, sizeof (zstrmctx));
   /* store wrapped stream as next stream */
-- 
2.51.0
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.