Re: Minor cleanup after adding more warnings to CFLAGS

On Sun, Mar 29, 2026 at 12:07:31PM +0200, Rene Kita wrote:
>I had some time and wanted to see how mutt compiles with more warnings
>enabled, i.e. CFLAGS='-Wall -Wcast-qual -Werror
>-Wimplicit-function-declaration -Wimplicit-int -Wnull-dereference
>-Wold-style-definition -Wredundant-decls -Wstrict-prototypes
>-Wstring-compare -Wtype-limits -Wuninitialized -Wunused'
>
>Turns out there's a lot the compiler complains about, especially when it
>comes to some const usage. The following patches are a result of this
>experiment and are far from a complete fix.
>
>This series depends on the proposed reformatting from Kevin. It's
>untested besides compilation and CI.

These look good.  Thanks for trying out those flags, they caught quite a 
few mistakes.

I'll push these up after a couple days, to give others a chance to at 
least glance at the reformatting patches if they want.

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEiXWpszqjeRA4XFMIre92hIAxa9oFAmnJEZUACgkQre92hIAx
a9q3xw/+NoYvp7RrQxWHIqY5SV7YjfkTL8Oc6tp9egYjR6CDTUct2UHyya0boLpl
DrOtvL/Mu8B4Wb3sFr/oWOuk7P8BxjxHTz8/Tma693XB6muclqB/KDsWZHAHIRjR
/JokYiv56gHupyRpgqLwf2Cq64/jrpbfIBBOlPBX2IzIoD60f4hZV9K+gFpj94RH
rv5sjNrKKwujWjsqLE+I9hNDKS9WD6ofMg1vuEUDkqerHUaPd8L5vl6rPmCEu9Uo
TQsge467WWnli75v53wZkUBg3pZCBf1svx4ucpRRgbX3YWx7sFtTooubCE/2Tk/J
cP/QrEE9fe2mbJTEF8T7B/Dmk1yGMsWJQ+CE9f/SxlfNqCeqWXb7r27H00AjMjXw
JElA0DZFg5AEb09q63bEJSgdPhvcZPDJ64N0GvO6v3ol5sxjqqMWA9nY2ESPslFb
GC2GxeLOI23vYyOjKwHiU8UB4CWmiuld5O+FnqTVjYmSOE1co2O/TXWh9HOsIRXM
oANhHGGVt1SfTiZDgbI4q6zptK/zp6H93THOQJRTSOEFJ2MJk8eEzvUFbgRs3D9J
NqeQWMbeBtCLGtw71Xw7caKMSI7ENe+nRyKcFskHSZ7R3LDS9DcNBcVv0xiOmiTe
3Ler3+2gCnqFiOToY1J3RpC3bPicuy64RwD+8iJhVRpkqEQP3Q0=
=vd7v
-----END PGP SIGNATURE-----