Re: [PATCH] Install new autoreconf files.

"Kevin J. McCarthy" <[email protected]> Tue, 14 Apr 2026 13:42:16 +0800

Newsgroups	gmane.mail.mutt.devel
Message-ID	<ad3TuF37BMJY34pV@qinghai>

On Tue, Apr 14, 2026 at 08:07:10AM +0800, Kevin J. McCarthy wrote:
>Here's what I plan on doing:
>
>1. Fix up the trixie docker image to include autopoint.  Just for 
>reference, I store these in the "docker-images" repository on gitlab: 
>https://gitlab.com/muttmua/docker-images
>
>2. Add "AM_GNU_GETTEXT_VERSION(0.21)" to configure.ac
>
>3. Remove and gitignore files that are reported as "Copy file" by 
>`gettextize -f --dry-run --no-changelog`
>
>4. Change prepare script to "autoreconf -isvf".  I like the idea of 
>the symlinks, since it makes it more obvious they are external files.
>
>Any comments?  Did I miss a step?

This is going well, except for new problems with 'make distcheck'.  I'm 
not sure whether it's due to using symlinks now, or because of newer 
files installed by autoreconf -f, but the distcheck build is now taking 
place in deeper subdirectories that are partitioned by source and _build 
and _install with permissions set.

The problem is that various 'make check' targets are failing because 
files don't exist inside the 'make distcheck' process.  For example, 
doc/Makefile.am validate fails because manual.xml is not found (since 
it's an intermediate generated file that isn't included in the tarball). 
I tried prepending with $(srcdir) and $(builddir) but neither worked. 
So eventually I just added an "if test -f ./manual.xml; then" around it.

But then check_sec.sh failed due to permission errors.  I changed that 
to pass --tmpdir to mktemp.  And now, shellcheck is failing because 
"gen_defs" doesn't exist, which we "echo" in additionally.

So I'm starting to wonder if these all should really be attached to the
'make check' target?  Any ideas?

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

signature.asc (application/pgp-signature, 833 B)