Re: [PATCH] Install new autoreconf files.
"Kevin J. McCarthy" <[email protected]>
| Newsgroups | gmane.mail.mutt.devel |
|---|---|
| Message-ID | <ad3hcLgsitFBZbQo@qinghai> |
On Tue, Apr 14, 2026 at 08:19:31AM +0200, Rene Kita wrote: >I fetched the MR, no objections from my side. Two small nits: >(1) I would use more consistent line wrapping in the Makefiles, e.g.: >#v+ >+ (find $(top_srcdir) -name \*.sh \ >+ && echo "$(srcdir)/gen_defs $(srcdir)/muttbug $(srcdir)/prepare") \ >+ | xargs shellcheck >#v- > >(2) Those file name prefixes (Makefile.am:, configure.ac:, CI:) in the > commit messages seem to be unusual for this project. > >(1) is really not important. Ah... I didn't look closely enough at the MR. Sorry Matthias, it looks like you are directly addressing the issue I just complained about. :-D. The first and third commit in your MR I've already taken care of in my branch, but I'll cherry pick the middle one and send a patchset in a little bit. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEiXWpszqjeRA4XFMIre92hIAxa9oFAmnd4XAACgkQre92hIAx a9rH4A/+JMvneS8vqOQX4mKpsjeItMcB05W695qD5l+/jHSwGf9e9s2YmCXHhOTl PXUPPhMmwDR8BiRn3OMF5UMHN/VJOs6H2YCxNfnEeCKdH+9MseozprabspfJxbrv MqUUPzCD92P/2jr2MChDtU046itNzrd1RKME+o//meJUVd0oaPSrb0pFUHnE/8gI /mBUa1rhKg8777PR3b7GB2OIDbgNeY5f+TDr1Urr4Rk5QkBQk6o++7sLFuHuTNbu UpUPak3P+vnMlScM8Ifrufold2s1zRQFHUvPLDq1tfcGpzGrO5JIcpzmn7wkRR9W 3hwkIFWHXQaB49GBx4fmvxXJY0gGzAriPnb84e5iLfJdt924LqUNh4q4qKccXmsR tbDiq3ilO48zMO9VT0sPQYwnjerkeVdNqWSZnf81+tTdb12gIapXsMtbiEcVTjNR gayt9IC4t5vwwX9Qj49gibFp6+wZJKH8MtBvCS6dLNqJ8tw7fTjNiOuBnKjlew7s bMEXHjkcRQcNAmG9oV0fkH9zqY8RCaLbvH3/a5R8t8Box3BHtNn6quU9wofCezps J0E2ivCvaOXlGrJRNM2HHUpwco11NBgmwyu3B77putA9RKuoNvDdJGw8wSj4L6z3 7o87UpjmQvBzE2dcPyuymFW5kVkcjwLRPQQB3Wrt1DTmI5V+IV0= =GuOK -----END PGP SIGNATURE-----