Re: Minor cleanup after adding more warnings to CFLAGS

Rene Kita <[email protected]>
Newsgroups gmane.mail.mutt.devel
Message-ID <[email protected]>
On Thu, Apr 16, 2026 at 09:16:52AM +0800, Kevin J. McCarthy wrote:
> On Wed, Apr 15, 2026 at 03:45:01PM +0200, Rene Kita wrote:
> > I played around a bit more and unless we are going to make -Wcast-qual a
> > default warning I don't think it's worth it to fix more warnings coming
> > from that flag.
> 
> Let's not take that step right now.  We've already done some good cleanup
> and fixed bugs in the process

Yes.

> > If we decide to go all in we should just drop every const where we can't
> > prove that we adhere to it.
> 
> Dropping consts all over in mutt would limit the usefulness of some other
> things, like mutt_b2s(), which returns a const char * because modifying the
> EOS without adjusting dptr results in bugs...
> 
> I'd be interested if we could get a little further along to safety by
> adopting the same mechanism glibc recently did for strchr and the others.  I
> haven't looked into what dark arts were involved.

Do you have some pointer for me to where I can get more infos about
those changes in glibc?
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.