Re: [PATCH] Remove autoconf check for sys/time.h header.
"Kevin J. McCarthy" <[email protected]> Tue, 28 Apr 2026 10:42:37 +0800
| Newsgroups | gmane.mail.mutt.devel |
|---|---|
| Message-ID | <afAeneasSFvTu5p3@qinghai> |
On Sat, Apr 25, 2026 at 01:19:07PM +0800, Kevin J. McCarthy wrote: >We've been including it init.c without an AC check for 16 years. > >As investigated by Alejandro Colomar: > > <sys/time.h> was standardized in POSIX.1-2001. And well before that, > 4.3BSD-Reno already had <sys/time.h>, with the file first added in 1983 > (although 4.3BSD-Reno was released later in 1990). > > <https://www.tuhs.org/cgi-bin/utree.pl?file=4.3BSD-Reno/src/sys/sys/time.h> > > Because every modern BSD is descendant of 4.3BSD-Reno, we know the file > is present in every version of FreeBSD/NetBSD/OpenBSD. > > glibc also has the file since the very first commit. > musl libc also has the file since the very first commit. > > I think we can assume the header exists in every Unix-like system. > > And checking gnulib documentation, it seems that the only platform that > lacks this header file was MSVC 14. Is mutt being built there? > If not, we could maybe remove that check in master everywhere. I've pushed this up. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEiXWpszqjeRA4XFMIre92hIAxa9oFAmnwHp0ACgkQre92hIAx a9qDZg/+IsrPvKtxNTZiOU3J/hBXmWoKq8zXwXBjn0gRkzpAQl7KGCX0wI8O8fJ4 YEHPaDKPPyZw3ffyXmfK9a8Wn6ORR/DXDKRRlzatD6Sfofnh+GdKEhB0C+p7l1+1 qcwxlnuPA5d5hh+9uoZ4hk4Wo3WTZ6dLoF/iecRN9Eoq/02ricfNSbwnNHP/ucTZ OkGUwUa+M5YNOtc84U4mZWU/j3Fn0W6765KQUfIiBKNpda5Pj7lVJMFKUlooQwzV qXVzGdeZfgBOmuzKiEMfgEAQLTCN04sapQS6u8XS9sBSyGr9y+l2Zf7Y3bRiHY3F m6pH6YWSf1W1uRydf06VymqcsYvMyVPwtvjauOeAAHz82Eqk5J//ir6OZPeQUGad 7Pztokw7KXxzGW/fRisCDLvHNAaAMsShnE7pUr0oXQ3ucQrgKmBpA17sqQ5H/haK PNAbCZwlAKR2/cCmyFQNwa+sSKZHvSi9t2pX0enR4Ya8aCrv9rYfLr+lfvhA3tj+ O/76XtIpZV+q0zKJsyuNvCVhWd2JI5ZkLDTLRbOqHdLXKtZO62EIip7TgRLEURNi 7vqCe7KyXu6O0NPbaBeOeqEPDcDsjb4zJsLSmQjKhI0jMxfZ6pgbtMzBtAW8ZC0B Q6mbIrydee+N8u3hYHwEl61taZ6jc/eiZs2NEWRFHZJCZRUfqmg= =ifLf -----END PGP SIGNATURE-----