Re: mutt_buffer_concat_path is broken [PATCH: 1/1] Version 2

"Kevin J. McCarthy" <[email protected]> Sat, 9 May 2026 09:27:15 +0800

Newsgroups	gmane.mail.mutt.devel
Message-ID	<af6Nc9eGB63QaCO0@qinghai>

On Fri, May 08, 2026 at 08:34:28PM +0200, Matthias Andree via Mutt-dev wrote:
>Am 08.05.26 um 06:57 schrieb Kevin J. McCarthy:
>>Fortunately I don't have to choose.  I had forgotten that there is 
>>another version of the function in lib.c: mutt_concat_path(). It's 
>>not called, but it should be fixed too.  And Alex's one-line fix 
>>applies easily there.
>
>If it's not called, why not delete it?

Yeah, at the time I kept it in because it was a "library" function that 
might in theory be helpful later.

But all the path code is using buffers now, so I guess it doesn't make 
sense to keep it.

I'll put on my todo list for 2.5 development to go through lib and 
remove unused functions.

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

signature.asc (application/pgp-signature, 833 B)