Re: [PATCH] Change mutt_buffer_concatn_path() to use fixed algorithm.

"Kevin J. McCarthy" <[email protected]> Tue, 19 May 2026 14:44:22 +0800

Newsgroups	gmane.mail.mutt.devel
Message-ID	<agwGxt-QZEq-RCVD@qinghai>

On Tue, May 19, 2026 at 01:56:45PM +0800, Kevin J. McCarthy wrote:
>*** This commit, however does cause a CHANGE OF BEHAVIOR. ***
>
>When the dir part is empty, the old algorithm concatn_path combines:
>  "" + "dir" => "dir"
>
>The new algorithm, now using mutt_buffer_concat_path, combines:
>  "" + "dir" => "/dir"

In defense of this change, however, I'll note that the existing code 
calling mutt_buffer_concat_path(), has always had this behavior, even 
before this previous fixes.

And so there are other places in the code which have always had this 
behavior, such as in init.c and hook.c.

This update is changing mutt_buffer_concatn_path() to have that same 
behavior.  The only difference is that it's at a user-interface prompt.

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

signature.asc (application/pgp-signature, 833 B)