Re: [PATCH] Fix pager search behavior with REG_NEWLINE.

"Kevin J. McCarthy" <[email protected]> Thu, 21 May 2026 19:32:22 +0800

Newsgroups	gmane.mail.mutt.devel
Message-ID	<ag7tRl6C0LiiRYd-@qinghai>

On Thu, May 21, 2026 at 12:57:39PM +0200, Alejandro Colomar via Mutt-dev wrote:
>> The search chunk was relocated into a function resolve_search().
>>
>> The newline removal/re-add was copied from a different function in the
>> pager code, match_body_patterns().
>>
>> > > diff --git a/pager.c b/pager.c
>> > > index 92fa152a..75221643 100644
>> > > --- a/pager.c
>> > > +++ b/pager.c
>> > > @@ -1268,6 +1268,47 @@ bail:
>> > >    return rc;
>> > >  }
>> > >
>> > > +static void resolve_search(struct line_t *lineInfo, int n, char *fmt,
>> > > +                           regex_t *SearchRE)
>
>Here, fmt is declared as char*, regardless of where it comes from
>(see below).

Ah, sorry.  Yes, you're right, I casted it in the call to this function 
but didn't update it here.  I'll do that.

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

signature.asc (application/pgp-signature, 833 B)