Re: [RFC PATCH] Use script to test build configurations
Oswald Buddenhagen via Mutt-dev <[email protected]> Sun, 31 May 2026 10:20:46 +0200
| Newsgroups | gmane.mail.mutt.devel |
|---|---|
| Message-ID | <[email protected]> |
On Sun, May 31, 2026 at 07:57:43AM +0200, Rene Kita wrote:
>Makes it easier to test locally and keeps the manifests dry.
>
the commit message should emphasize the fact that you are centralizing
the configure command line args.
>+++ b/build
>+tcc()
>+{
>+ CC=tcc ./configure
>
no tab here?
>+# If no arguments were passed, get all the above function names
>(except _die)
>+# and drop the parentheses.
>
this is kind of redundant with the description at the top, esp. the
naming of the function.
>+for conf
>+do
>+ cflags="$dft_flags"
>+ make distclean || :
>+ autoreconf -fi || _die "$?" "$conf" autoreconf
>
it makes no sense to have this in the loop. distclean does not (or at
least should not) remove auto* artifacts.
it would be different if you used `git clean -xfd` as the cleaning
command, but that would be an awesome footgun.