Re: [PATCH] Fix configure --with-bundled-regex test.

"Kevin J. McCarthy" <[email protected]> Thu, 4 Jun 2026 18:42:06 +0800

Newsgroups	gmane.mail.mutt.devel
Message-ID	<[email protected]>

On Wed, Jun 03, 2026 at 09:45:40PM +0800, Kevin J. McCarthy wrote:
>The documentation in autoconf says:
>
> — Macro: AC_ARG_WITH(PACKAGE, HELP-STRING, [ACTION-IF-GIVEN],
>          [ACTION-IF-NOT-GIVEN])
>     If the user gave ‘configure’ the option ‘--with-PACKAGE’ or
>     ‘--without-PACKAGE’, run shell commands ACTION-IF-GIVEN.  If
>     neither option was given, run shell commands ACTION-IF-NOT-GIVEN.
>
>This means the third parameter is evaluatated in both cases:
>--with-bundled-regex and --without-bundled-regex.
>And thus the code was incorrectly turning mutt_cv_regex on for both
>cases, skipping the broken regex test further below.
>
>Fix it to properly set mutt_cv_regex.  Further below, configure will
>check the built-in system regex works if the value is 'no'.

I don't think this is very controversial, so I've pushed it up to master 
to be included in the 2.4.0 release.

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

signature.asc (application/pgp-signature, 833 B)