Re: More AI agent merge requests

--art6upny4od3ldzz
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
From: Alejandro Colomar <[email protected]>
To: [email protected]
Subject: Re: More AI agent merge requests
Message-ID: <akOEQxYywzKcarJM@devuan>
References: <[email protected]>
MIME-Version: 1.0
In-Reply-To: <[email protected]>

Hi Kevin,

On 2026-06-30T13:05:27+0800, Kevin J. McCarthy wrote:
> I don't think any of these are high priority, except perhaps for !198. I'd
> appreciate anyone willing to take a look at these and add their feedback.

Hmmm, !198 is interesting, not only for the bug it reports, but as a
reminder that there's another bug: overflow in the multiplication in
realloc(3) calls.

The solution to overflow in realloc(3) calls must be solved by calling
reallocarray(3).  I already solved this problem in neomutt(1) a few
years ago.

	neomutt.git 404938be1053 (2024-11-14; "Use mutt_mem_reallocarray()")

reallocarray(3) is in POSIX.1-2024, and is relatively portable:
	glibc 2.26, OpenBSD 5.6, FreeBSD 11.0
However, it is missing at least in a current system: MacOS.  The good
news is that it's trivial to implement if it's missing.

	neomutt.git 8919dcdd2b63 (2024-11-15; "mutt/memory.c: Add reallocarray() i=
mplementation if missing")

> Mutt in general hasn't placed hard limits all over, because in general
> people connecting to IMAP/POP3 servers have some implicit trust in the ho=
st
> of their email, unlike just a random website.
>=20
> * https://gitlab.com/muttmua/mutt/-/merge_requests/198
> This one seems okay to me.  It seems right that the blen should be the sa=
me
> type as len.

I haven't looked much into it, but it seems reasonable.

> * https://gitlab.com/muttmua/mutt/-/merge_requests/199
> No comment on this one for now.
>=20
> * https://gitlab.com/muttmua/mutt/-/merge_requests/200
> This one has an extra "garbage" file placed inside contrib.  A pretty dead
> giveaway that this is just an agent.  Otherwise no comment.

I don't like this one.

> * https://gitlab.com/muttmua/mutt/-/merge_requests/201
> No comment on this one for now.
>=20
> Again, I would greatly appreciate anyone who has the time to take a look =
at
> the patches too.  I'll try to do so this weekend.


Have a lovely day!
Alex

--=20
<https://www.alejandro-colomar.es>

--art6upny4od3ldzz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEES7Jt9u9GbmlWADAi64mZXMKQwqkFAmpDh2MACgkQ64mZXMKQ
wqn1AQ//fGMVAzAAnI1x+gwBIHMmWuvORUr2GPEaoqNoECrHgPVV/aVWviVbFK/5
ynNzbc/9sg/zDLnjee4swBvlUDAsq9uZ0tmj+GERmPA9E0tHex1KC0vdF+K5OQT1
P8SJ8eHapgHzmNuu+qHNx7CTw4oCnOKEjOZ/NXnbMTRgvChslG01JbM+MbWnVwfa
4rrM0Cg1mDNqWfts5Wr1Ds8RIwXsOvJ0MhCZOCuRvsBKNqVzTBISkl29LBv84jJ8
X+uJUiWvrL9onyxY7mZwK6uVmwffGtvOjGZF+2PgYhH2q4MT4RPEVbRyWVxOEdMs
p+M43k+fd9iAkZlsdkStpg6ouUFnV4Kjw4nLpI6u90dml4LGoPhct5cRKeriOg8o
zoSJAASJSfZ7C+PglG1iCaqpbJA0KZUEzkki1tLRaMTZ5EJ3E26gw1fk3ZnoC0u5
KPh3wiZa5gkEAwyENJLSlHKr5MK4gaS8QAwfIdEQulz3OmdpwWGL/llYiQu9wkb/
lhnTRBUhxoIglH7msZlRJ4L4IWfz3sVwUyhvZNchYeg/6Xw+qfoD3i5XqAr4onxz
hL/Mu3rwkjNIjqIWKUbdM88vp3tgu/6/wSd4J0smI2RNjmleC7mTc5w1OjybCQPo
t8TmWb3O53VZyX0A/6wrj87Tc2HQKU1lSlUlRa0etO0NyI26+hw=
=zvQx
-----END PGP SIGNATURE-----

--art6upny4od3ldzz--