Re: [PATCH] show s/mime keyid for successfully checked signatures

--rishva3b3ox6pztv
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
From: Alejandro Colomar <[email protected]>
To: Robert =?utf-8?Q?J=C3=A4schke?= <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] show s/mime keyid for successfully checked signatures
Message-ID: <akbR4-G-79RmR_qD@devuan>
References: <[email protected]>
 <[email protected]>
 <[email protected]>
 <[email protected]>
 <[email protected]>
MIME-Version: 1.0
In-Reply-To: <[email protected]>

On 2026-07-02T22:26:32+0200, Robert J=C3=A4schke via Mutt-dev wrote:
[...]
> So here are my two patches (thanks also to Alejandro for the tipps to
> improve my code):
>=20
>=20
> -- >8 --
> Subject: [PATCH 1/2] refactored alignment of strings into function

For the first patch:

	Reviewed-by: Alejandro Colomar <[email protected]>


Have a lovely night!
Alex

> ---
>  crypt-gpgme.c | 19 +++----------------
>  curs_lib.c    | 11 +++++++++++
>  protos.h      |  1 +
>  3 files changed, 15 insertions(+), 16 deletions(-)
[...]
> -- >8 --
> Subject: [PATCH 2/2] show s/mime keyid for successfully checked signatures
>=20
> ---
>  crypt-gpgme.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/crypt-gpgme.c b/crypt-gpgme.c
> index 4e0be87f..5fa7b7e5 100644
> --- a/crypt-gpgme.c
> +++ b/crypt-gpgme.c
> @@ -1528,12 +1528,11 @@ static int show_sig_summary(unsigned long sum,
>  }
> =20
> =20
> -static void show_fingerprint(gpgme_key_t key, STATE *state)
> +static void show_fingerprint(const char *msg, gpgme_key_t key, STATE *st=
ate)
>  {
>    const char *s;
>    int i, is_pgp;
>    char *buf, *p;
> -  const char *prefix =3D _("Fingerprint: ");
> =20
>    if (!key)
>      return;
> @@ -1542,9 +1541,9 @@ static void show_fingerprint(gpgme_key_t key, STATE=
 *state)
>      return;
>    is_pgp =3D (key->protocol =3D=3D GPGME_PROTOCOL_OpenPGP);
> =20
> -  buf =3D safe_malloc( strlen(prefix) + strlen(s) * 4 + 2 );
> -  strcpy(buf, prefix); /* __STRCPY_CHECKED__ */
> -  p =3D buf + strlen(buf);
> +  mutt_align_to_msg(msg, _("Fingerprint: "), state);
> +  buf =3D safe_malloc( strlen(s) * 4 + 2 );
> +  p =3D buf;
>    if (is_pgp && strlen(s) =3D=3D 40)
>      {  /* PGP v4 style formatted. */
>        for (i=3D0; *s && s[1] && s[2] && s[3] && s[4]; s +=3D 4, i++)
> @@ -1638,6 +1637,8 @@ static void print_smime_keyinfo(const char *msg, gp=
gme_signature_t sig,
> =20
>        aka =3D 1;
>      }
> +
> +    show_fingerprint(msg, key, s);
>    }
>    else
>    {
> @@ -1755,7 +1756,6 @@ static int show_one_sig_status(gpgme_ctx_t ctx, int=
 idx, STATE *s)
>             ultimate). */
>          print_smime_keyinfo(_("Good signature from:"), sig, key, s);
>          show_one_sig_validity(ctx, idx, s);
> -        show_fingerprint(key,s);
>          if (show_sig_summary(sum, ctx, key, idx, s, sig))
>            anywarn =3D 1;
>        }
> --=20
> 2.47.3
>=20
>=20

--=20
<https://www.alejandro-colomar.es>

--rishva3b3ox6pztv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEES7Jt9u9GbmlWADAi64mZXMKQwqkFAmpG0lkACgkQ64mZXMKQ
wqlTBg//WsJvoAeqeHc5KfqnlCjyIj0Syc7Ok+mB0ZPV/ya9ftd+KpucLwEQnY5K
D9gXAFiKf+ro71XNfAbvF6ElZaPFssx1Y9P4ZAZRbzi8jeeY+Ck7z/zomaYOwUL3
gimkuSJAGmUbwoBdulTxvJK7Pes9zXevAzSMI5j04MB+cUnPIKtHpSa7REVR6Lt6
fpIR8kiZRaGE5I770fer57BZPqv2dfWiHvEdnsjkou/zbL0G2FJMenfZIHrg61is
CelFiOAs+bPh+SjIL6T3Sv3Nf/u4ulZUymXwO5moy64sGn80lmi0npifVHPkhGOm
PI7wwVLn4ybPuQM9D8HLy2Zm4piUcYJ7U2/EOCy3lC44hF6BvjzpfaEAgZ81gJ3v
3lW1GYGD0hPXneeUzJtywb4qZ306ERntEnbahK7lu+gQ/JlGpbdpWvCfiIusRy7n
GalzPzozxgufw/78fcBvGXDzI7FA4Av40lqbMUeRqKtAu2TJDy8CkVWmBFAX5MlF
N/q79+LSP3mP538b5XnQC7o4bbvtg3vLFm5VDfcsW5C2ZMb6Pyjn4j38b3pj978S
JUwp5PA96M6e7UTnopMdHchRzttCP6SNrjaqQtCV3FPvNO6NlPAEaCDS1kNuTdiy
+EezvdjcZEa8wOsSwGRaTzFTu/NZbBUzYcswx6mPvS1M+gfR9bo=
=SdqY
-----END PGP SIGNATURE-----

--rishva3b3ox6pztv--