Re: [PATCH v2] Simplify maildir_delayed_parsing().

--pec6j4kmppeywtru
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
From: Alejandro Colomar <[email protected]>
To: Rene Kita <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH v2] Simplify maildir_delayed_parsing().
Message-ID: <al8_8MjS2XOnFy9f@devuan>
References: <[email protected]>
 <[email protected]>
 <[email protected]>
 <[email protected]>
MIME-Version: 1.0
In-Reply-To: <[email protected]>

Hi Kevin, Rene,

On 2026-07-21T06:22:14+0200, Rene Kita wrote:
> On Tue, Jul 21, 2026 at 10:32:12AM +0800, Kevin J. McCarthy wrote:
> > On Mon, Jul 20, 2026 at 03:10:28PM -0400, Kurt Hackenberg wrote:
> > > Programmers are notoriously bad at guessing where software spends its
> > > time. The standard advice is to *measure* speed if you're concerned
> > > about it.
> > >=20
> > > Applying that advice, I guess anyone tempted to remove this speed hack
> > > should measure speed first, with and without the hack, in at least all
> > > the cases above. And remember that disk drives and filesystems both h=
ave
> > > cache. A lot of work...
> >=20
> > Yup.  Personally, I would love to completely remove the sort.  It would
> > make the function a lot cleaner.
> >=20
> > But it would be a lot of work to measure.
>=20
> As it complicates the code, I would argue that those who want to keep
> the function should do the measurement. Kurt gave enough arguments why
> this sorting is a questionable idea.

+1


Have a lovely day!
Alex

> But I also understand you being
> cautious.

>=20
> See also: https://xkcd.com/1172/ :-)

--=20
<https://www.alejandro-colomar.es>

--pec6j4kmppeywtru
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEES7Jt9u9GbmlWADAi64mZXMKQwqkFAmpfQCMACgkQ64mZXMKQ
wqlziQ/9EN0TwP3wd42G8nmeVKyNtqleqlY1R396Q2pbF8lx4muUON0OoFD90vri
MG8rJ2V+2UbEiJtMi85TfpWBwi4VKoXyi4tFSa5l4akhSjlNR8GqemZnB8yuuW5A
UHZ21wlb2bKmo5kJtV49sHWTmv4kCq52b+YGUH0M8K0x6EWu4kgVog3pkmyDlyxL
yCu/lZL6BcOtN1svV2yNwE7cUMb+8C0M7rRZ+pnA+yJmk+bUKx899+RmK2vNCfdp
5OXT+l8dCexbTjkvpuysQf9rhPxPSluXCauTFvH4d/5fkyhODpD/bXusBWyIrxTe
74Yre64lhco15SZZi3crkoHrPlaQW9kEAFH1h7rfZ3bReBnLN0d7G6ApMIT/VVEv
KBuTjop6InhrxHam/WAwASUqACLWNJQ8IkqrWdT6po02PdwPGQstziyr1gyMWPEj
3bljj02gagsZrTN6cv63WuLGQS8+IvTqYmBgAA3IlTpONO+KuatWo8AiwEi6xBLq
HbdZn8r90a8ZFdWO6Q9N12mrzC00Ccfqtff1lBh0afjr3DhvFcqFq23GwtE8tHtm
fi+IbUGW6BGvTZFoH6fEcXqTsrPpp95P90kowV1oCIf8bmi8WF8oxPj/CP5QkNgv
K1E/ZislF8YWwLaZ7gTIC0mWQHMNzDzM7pRjD1ZHsDMIwYHq5zg=
=96Na
-----END PGP SIGNATURE-----

--pec6j4kmppeywtru--