Re: [PATCH] Change attachment stamping to use stat st_mtime by default.

On Thu, Aug 20, 2026 at 12:49:04PM +0200, Oswald Buddenhagen via Mutt-dev wrote:
>On Thu, Aug 20, 2026 at 12:44:29PM +0200, Vincent Lefevre wrote:
>>On 2026-08-20 12:29:57 +0200, Oswald Buddenhagen via Mutt-dev wrote:
>>>On Thu, Aug 20, 2026 at 10:54:23AM +0800, Kevin J. McCarthy wrote:
>>>> This can result in time() being earlier than the mtime of a file
>>>> just modified.
>>>> it can't, as long as only the full seconds are compared.
>>
>>It can (even if you take the nanoseconds of st_mtim into account
>>as they are non-negative[*]), as shown by the tests.
>>
>that's besides the point.

No, that is the whole point of the patch.

>the reasoning as given by the commit message is bogus.

Feel free to suggest wording changes, but try a little not to be so 
harsh.  Thanks!

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEiXWpszqjeRA4XFMIre92hIAxa9oFAmqG5gQACgkQre92hIAx
a9qFdw/+KFxn/0hS+j2oKkQRmAsahSfGxoLKttk7OlAfKbwwOhCEGT+NklidA8LO
+D935SOT8ifjHm4R5M2by3jR9zi0V+X0tUsAIXV4CSbx1iEvLS/xqJK4hwoPe06K
QrRLaitWg+rloUOvHamwCKbj7dOJMymN21RcssSHPEo/IZ54LTinSTffOGuo5OyO
2zK9m5qJDxF+ehxau699rK2t+WGP57wrt5HZnduoBMX/z0iZZIttQVU2/7345jMN
xn8XTscLhcEnaA4Ygq21YiXjkQ25gedIG/YxdyzuZPOi1owfkbMLbXCwUMNOFEuv
Mw171XwP/oKbHtY7HVcy+WEbAT1hV+JwZVX7y9hfVG18oovfUO0AtBkcNwvF2UX7
71OBgqfQABgAJg2GZzLcIsaCoTNmhYYnhxIp4D6LWpn9mgAuf9T5dKnhN+sRWNox
5OvQY7BRymKJv7xRw2HAyeMhM4Gl0N7Odctusq5T9hJfl1b2EGmWTpJUop55VCC4
6pZalQYsl4A/z4+9Iz7xxapKT76G58GQCGso/c+d0tGZjP44DryuHvoJBHRMghJI
mmNLZBZ2SXMcfQh4l81ecojbEBP9f7KzfJuqkPg2oxb5egp6NcHG3of4vwS8Ez5a
QcwUPA/UcswU/3HxYX5e8gwYFRhuAv92Xx5sJEuEzn/aVSfjNeg=
=ZNjS
-----END PGP SIGNATURE-----