Re: [PATCH] Change attachment stamping to use stat st_mtime by default.
Vincent Lefevre <[email protected]>
| Newsgroups | gmane.mail.mutt.devel |
|---|---|
| Message-ID | <[email protected]> |
On 2026-08-21 11:00:58 -0000, Crystal Kolipe via Mutt-dev wrote: > On Fri, Aug 21, 2026 at 10:09:27AM +0200, Vincent Lefevre wrote: > > (actually, we want to know whether the file contents have changed). > > Then the correct and portable way to do it is to check file size, > and if that has not changed then check the actual contents. True. This is what *must* be done. Comparing the contents should be based on a cryptographic hash because the old contents are no longer available. The current Mutt behavior is buggy (on any platform): replacing an attachment (e.g. with "mv") by an one that isn't more recent is undetected by Mutt, while the goal of the test is to detect a replacement to ensure that the encoding is correct. -- Vincent Lefèvre <[email protected]> - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / Pascaline project (LIP, ENS-Lyon)