Re: [PATCH 1/2] Fix <get-attachment> to use $tmpdraftdir.

Alejandro Colomar via Mutt-dev <[email protected]> Tue, 25 Aug 2026 12:51:14 +0200

Newsgroups	gmane.mail.mutt.devel
Message-ID	<ao1y7BVfH3P4Lr1d@devuan>

Hi Kevin,

> Date: 2026-08-25 18:00:24+0800
> From: "Kevin J. McCarthy" <[email protected]>
>
[...]
> diff --git a/rfc1524.c b/rfc1524.c
> index f1b13fc9..b14436c1 100644
> --- a/rfc1524.c
> +++ b/rfc1524.c
> @@ -494,9 +494,9 @@ int rfc1524_mailcap_lookup(BODY *a, char *type, size_t typelen, rfc1524_entry *e
>   * template and/or the old file name will be used for the
>   * comparison and the temporary file name.
>   */
> -void mutt_rfc1524_expand_filename(const char *nametemplate,
> -                                  const char *oldfile,
> -                                  BUFFER *newfile)
> +static void _rfc1524_expand_filename(const char *nametemplate,
> +                                     const char *oldfile,
> +                                     BUFFER *newfile)

It's technically undefined behavior to declare an identifier starting
with '_lowercase' in file scope.  (I ignore if we already have of those,
and thus this is just consistent with existing practice; also, it's
unlikely that glibc will define anything similar, so it should be fine.)

Feel free to ignore this comment.  :)


Have a lovely day!
Alex

-- 
<https://www.alejandro-colomar.es>

signature.asc (application/pgp-signature, 833 B)