Re: [PATCH 2/2] Fix <get-attachment> to remove attachments upon compose abort.

"Kevin J. McCarthy" <[email protected]> Tue, 25 Aug 2026 19:25:13 +0800

Newsgroups	gmane.mail.mutt.devel
Message-ID	<[email protected]>

On Tue, Aug 25, 2026 at 12:56:30PM +0200, Alejandro Colomar via Mutt-dev wrote:
>> Date: 2026-08-25 18:00:25+0800
>> From: "Kevin J. McCarthy" <[email protected]>
>>
>> +          for (i = 0; i < actx->idxlen; i++)
>> +            if (actx->idx[i]->content->tagged &&
>> +                (mutt_get_tmp_attachment(actx->idx[i]->content) == 0))
>> +            {
>> +              actx->idx[i]->unowned = 0;
>> +            }
>
>This for loop feels quite weird (due to braces).  How about reversing
>one condition to split them?
>
>	for (i = 0; i < actx->idxlen; i++)
>	{
>	  if (!actx->idx[i]->content->tagged)
>	    continue;
>	  if (mutt_get_tmp_attachment(actx->idx[i]->content) == 0)
>	    actx->idx[i]->unowned = 0;
>	}

Sure.  Thanks Alex!

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

signature.asc (application/pgp-signature, 833 B)