Re: Error adding host name in greeting message on Perdition 1.19-rc2

On Sun, Jul 25, 2010 at 05:42:15PM +0200, Joachim Sehlstedt wrote:
>   Hi,
> 
> There is an error adding the host name to the greeting message. I have 
> found the following:
> 
> With no_bind_banner and no_lookup = no problem
> * OK [CAPABILITY IMAP4 IMAP4rev1 LITERAL+] perdition ready on mail 0002c797
> 
> With no_bind_banner, without no_lookup = no problem
> * OK [CAPABILITY IMAP4 IMAP4rev1 LITERAL+] perdition ready on mail 0002c936
> 
> Without no_bind_banner, with no_lookup = problem
> * OK [CAPABILITY IMAP4 IMAP4rev1 LITERAL+] perdition ready on 
> zÃÿ¿¤ÇA·@P·@P·ÐhÃÿ¿y     0 0002c7f5

Hi Joachim,

thanks for pointing that out. The following patch should resolve the problem.

# HG changeset patch
# User Simon Horman <[email protected]>
# Date 1280125744 -32400
# Node ID 957261a39569c5522ba74b39a8eb702298ba4d0a
# Parent  53b6da83e9f6ff33b7e05b2acd0d3cae00434492
core: Initialise host portion of greeting for no_lookup, !no_bind_banner

If no_bind_banner is not in effect and no_lookup is in effect then
getnameinfo_try_lookup does nothing and the hostname portion of
the bind banner is left uninitialised.

As pointed out by Joachim Sehlstedt <[email protected]>

Signed-off-by: Simon Horman <[email protected]>

diff -r 53b6da83e9f6 -r 957261a39569 perdition/greeting.c
--- a/perdition/greeting.c	Mon Jul 26 13:05:59 2010 +0900
+++ b/perdition/greeting.c	Mon Jul 26 15:29:04 2010 +0900
@@ -69,7 +69,7 @@
 
 int getnameinfo_try_lookup(struct sockaddr *addr, char *host, size_t hostlen)
 {
-	int rc = 0;
+	int rc = EAI_AGAIN;
 
 	if (!opt.no_lookup)
 		rc = getnameinfo(addr, perdition_get_salen(addr),
______________________________________________
Perdition-users mailing list
[email protected]
http://lists.vergenet.net/listinfo/perdition-users