flowing bug with ^V

I've found the following problem with pine:

If quell-flowed-text is unset (and some other thing are true), 
pine_send() will set pbf->allow_flowed_text. Then you edit the message in 
pico, and eventually, the exit callback is called, with the last argument 
taken from Pmaster->allow_flowed_text. The exit callback is 
send_exit_for_pico in this case, and it uses it's last argument to set the 
send.c file global flowing_requested, and then lets the user toggle 
flowing_requested with ^V (all the other callbacks ignore the parameter).

But the information in flowing_requested is never propagated back to pico, 
so it flows the message in cleanwhitespace(), regardless!

Finally, after pico returns, flowing_requested is given to 
strings2outgoing(), which uses it to set format=flowed in the headers. The 
end result is that you can get a message without format=flowed set, but 
you cannot prevent the message from being flowed unless you've set 
quell-flowed-text to disable this feature entirely.

I'm not sure how to fix this bug. I think that exporting the send.c global 
would break standalone pico. Changing the last parameter of the exittest 
interface to a pointer to Pmaster->allow_flowed_text so the callback can 
change it should work. Or perhaps there needs to be an extra int* 
parameter to the exittest interface that is set by the callback function 
and tested by pico() before it calls cleanwhitespace()? Let me know, and 
I'll cook up a patch.

 			Alexey
_______________________________________________
Pine-info mailing list
[email protected]
http://mailman1.u.washington.edu/mailman/listinfo/pine-info