Re: qmailadmin has problems with ezmlm-idx 7.0.2: Patch

Johannes Weberhofer <[email protected]> Thu, 18 Aug 2011 13:49:26 +0200
Newsgroups gmane.mail.qmail.admin
Message-ID <[email protected]>
I have added a patch for that issue on sourceforge some time ago. It's running here on my systems:

http://sourceforge.net/tracker/?func=detail&aid=3094082&group_id=6691&atid=306691

Johannes

Am 18.08.11 10:38, schrieb Robert Schulze:
> Hi,
>
> Am 17.08.2011 17:03, schrieb Tom Collins:
>> "if (dbuf)" will always be true, since you're referring to the array.
>
> oops, I fixed that.
>
>> I
>> think you want "if (*dbuf)" (e.g., if the first character of dbuf is not
>> null). Likewise, your test of "strcmp(dir,"")==0" would be clearer as
>> just "*dir == '\0'".
>
> I think comparing strings with strcmp ist OK.
>
>>
>> Use "strcpy" instead of "sprintf" to copy strings like this:
>> sprintf(dbuf,"digest").
>
> thats right, fixed.
>
> A new patch is attached.
>
> with kind regards,
> Robert Schulze
>
>
> 

-- 
Johannes Weberhofer
Weberhofer GmbH, Austria, Vienna

!DSPAM:4e4cfc4a32711645020277!