Re: qmail-ldap-1.03-20120221.patch

On Fri, Feb 24, 2012 at 06:55:35PM +0200, Ismail YENIGUL wrote:
> Hello,
> 
> On 24.02.2012 18:15, Claudio Jeker wrote:
> >Can you send me the exact Makefile definitions you used to build?
> >I will see that we can fix this...
> Ok I see the problem. I forget to comment out #LDAPFLAGS= line.
> Now this part is OK.
> Only problem is with loglevel in auth_dovecot.

This is a missing #ifdef DEBUG in auth_dovecot.c the attached patch should
solve this.

The issue with the #error XXX XXX when compiling without -DDASH_EXT is
currently unclear to me. I commited that 3 years ago :( and I need to
read the code again to understand why I did that (maybe some stupid debug
code was commited).

> Btw, Do you have any plan for IPv6 support?

Currently there is no plan (AFAIK). It would require some massive work to
make this happen.

> Me and my colleague is working on to fix depreciated functions in
> LDAP to avoid DLDAP_DEPRECATED declration for OpenLDAP 2.4

That would be appreciated. This is one thing that is currently on my TODO
list.

> I think, it would great to create a tarball contain all these
> patches as a distribution callled something qmail-ldap version X

Andre is in charge of making the diffs and in that case tarballs. It is up
to him.

-- 
:wq Claudio

Index: auth_dovecot.c
===================================================================
RCS file: /home/cvs-djbware/CVS/qmail-ldap/auth_dovecot.c,v
retrieving revision 1.2
diff -u -p -r1.2 auth_dovecot.c
--- auth_dovecot.c	17 Apr 2009 19:51:58 -0000	1.2
+++ auth_dovecot.c	25 Feb 2012 00:08:05 -0000
@@ -127,7 +127,9 @@ auth_setup(struct credentials *c)
 void
 auth_init(int argc, char **argv, stralloc *login, stralloc *authdata)
 {
+#ifdef DEBUG
 	extern unsigned long loglevel;
+#endif
 	char		*l, *p;
 	unsigned int	uplen, u;
 	int		n, opt;
@@ -140,10 +142,12 @@ auth_init(int argc, char **argv, strallo
 		case 'd':
 			pbstool = optarg;
 			break;
+#ifdef DEBUG
 		case 'D':
 			scan_ulong(optarg, &loglevel);
 			loglevel &= ~256;	/* see auth_mod.c */
 			break;
+#endif
 		default:
 			auth_error(AUTH_CONF);
 		}