Re: qmail-scanner 2.01-st patch questions/comments

At 13:21 -0600 1-01-2007, Josh Trutwin wrote:
>     if (/\;|\!/) {
>
>to this:
>
>     if (/\;/) {
>
>Is there a valid reason for not allowing the "!" character in the
>file? It seems to work fine with this modification.

Hi

There is no problem on doing that for you, I don't really remember 
why I removed the '!' maybe because there are some checks about 
sa_subject and if it starts with a '!' some of the could be broken...

>Next - when I ran qmail-scanner.pl -p to produce the SPD all went
>fine, but running -d I noticed my spamdir was lowercased!  I have
>existing client spam dirs as ".SPAM" maildir - so lowercasing is
>not an option!  I commented this line:
>
>$domain_settings=tolower("$domain_settings");
>
>in generate_spd again to fix this.  I don't see why you would want
>to lowercase something like this?

Neither I, again I don't remember why I did that, maybe it was for 
the scanners names, but it is not neccessari for the directories or 
sa_subject.

>
>You will notice that I have full paths to my SPAM dir in the
>settings_per_domain.txt file.  Each user already has a SPAM IMAP
>dir, I wanted to use sa_quarantene to essentially quarantene the
>message to this IMAP dir so they can log into an IMAP client like
>webmail to view these messages instead of me having to administer
>them from some structure in /var/spool/qscan/quarantene -
>unfortunately, the code here was a little too tricky for me to muck
>with so I created a symbolic
>link 
>/var/spool/qscan/quarantene//usr/local/sites/www.netbits.us/users/josh/.SPAM
>which points to /usr/local/sites/www.netbits.us/users/josh/.SPAM -
>this required updating the -d test in email_quarantine_report to:
>
>if (! -w "$scandir/quarantine/$smaildir")

Sorry, I don't understand... (I don't use this feature somebody asked for it)

I have to check something like this

ln -s /usr/local/sites/www.netbits.us/users /var/spool/qscan/quarantine/users

and $smaildir='users/josh/.SPAM'

>It would be nice to have absolute path support for sa-spamdir in
>future versions - but this is kind of a permissions headache so I
>can see what it's not there...

Absolute path... this is dangerous

>FINALLY - when doing all this I needed to change the code because
>my /usr partition is different from /var - the code to uncomment
>was:
>
>     #use File::Copy
>     #copy ("$scandir/$wmaildir/new/$file_id" etc etc
>
>There was no semi-colon after File::Copy so this caused errors /
>temp qmail queue failure until I fixed it.

Ok, I will fix it.

Regards

ST


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV