Re: JR's patch to not send confirms for obvious spam

Hi Marc & JR.

Great work. Thanks a lot. I couldn't have said wiser words myself. :)))

JR, thanks for the great patches. I'll proceed to patch ASK and do minor
modifications, if needed.

Regards,
Paga

On Wed, May 26, 2004 at 10:42:33AM +0200, Marc Herbert wrote:
> On Mon, 24 May 2004, J.R. Oldroyd wrote:
> 
> > On analysis it seems that all of the spam that is getting through falls
> > into two categories:
> > 	- message appears to be from mailer-daemon
> > 	- spammer is replying to ASK's confirm message
> >
> > I would like to offer the patch below which addresses both of these
> > problems.  Using it, I am back to zero spam, and so far, no false
> > positives.  This is a patch to ASK 2.4.1-1.
> >
> 
> J.R., this is really great work, thanks a lot !
> 
> 
> This is especially interesting since it implements two already
> "wanted"  features, as you can read here:
> 
> [ 873762 ] "Bulkier" or "MeNotRecipient" destination folder
> <http://sourceforge.net/tracker/index.php?func=detail&aid=873762&group_id=42266&atid=432548>
> 
> [ 953530 ] spam from postmaster pass through ask
> <http://sourceforge.net/tracker/index.php?func=detail&aid=953530&group_id=42266&atid=432548>
> 
> 
> To make work much easier for the developer, I suggest you upload your
> patches to the sourceforge trackers. It will also help other
> users/testers find them in the future, not having to painfully search
> the mailing-list.
> 
> Please first split your patch into two different patchs : on patch per
> logical change is easier to manage/test/etc.
> 
> Since the sourceforge tracker unfortunately does not allow you to
> attach files to RFEs (unless you own them), I suggest you upload your
> patches using the _other_ "patches" tracker. Do NOT try to copy-paste
> your patches into some "comments" field, they will end up corrupted
> because of wrapped lines, tabulations removed etc.
> 
> To submit new patches, use this form:
>  <http://sourceforge.net/tracker/?func=add&group_id=42266&atid=432547>
> Then you can come back to the two RFEs above and add there
> in the comments field relevant pointers to your patches (if anyone has
> a more direct solution, please say so)
> 
> If you don't have a sourceforge account yet, I strongly suggest you
> create one _before that_, as it will make the operations above (and in
> the future) much easier.
> 
> 
> > 3.  The patch also restores the use of the rc_junkmailbox and
> >     rc_bulkmailbox variables.  If these variables are defined, email
> >     classified as Junk or Bulk will be saved in those files.  If the
> >     variables are not defined, such email is saved in the queue dir,
> >     which is the current functionality.
> 
> This function was already restored in the current CVS version
> (2.5.0++). If you have the time, I suggest you port your two patches
> to the current development version: 2.5.0, since 2.4.1 is supposed to
> receive only bug fixes, and not new features.
> 
> (I am using version 2.5.0 daily, and it's fine).
> 
> 
> > 4.  Finally, the patch also adds a blank line in the log at the start
> >     of each ASK run and corrects an instance where "mailer-daemon" was
> >     logged as "mailer_daemon".  This is just to make the log a little
> >     easier to read and search.
> 
> Please also split this into a different, extra patch : on patch per
> logical change is easier to manage/test/etc.
> 
> Thanks again a lot for your work !
> 
> Cheers,
> 
> Marc.
> 
> 
> 
> PS: Marco, please correct me where I'm wrong.
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: Oracle 10g
> Get certified on the hottest thing ever to hit the market... Oracle 10g.
> Take an Oracle 10g class now, and we'll give you the exam FREE.
> http://ads.osdn.com/?ad_id149&alloc_id66&op=click
> _______________________________________________
> A-S-K-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/a-s-k-users
> 

-- 
Marco Paganini          | UNIX / Linux / Networking
[email protected]   | PGP: http://www.paganini.net/pgp/
http://www.paganini.net | Magnus Frater te spectat...


-------------------------------------------------------
This SF.Net email is sponsored by the new InstallShield X.
From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and
evaluate today! http://www.installshield.com/Dev2Dev/0504