Re: wget build: is this normal?

-------- Original-Nachricht --------
> Datum: Fri, 26 Sep 2008 02:28:29 +0200
> Von: "Ger Hobbelt" <[email protected]>
> An: Steve <[email protected]>
> CC: [email protected]
> Betreff: Re: [Crm114-general] wget build: is this normal?

> On Fri, Sep 26, 2008 at 12:39 AM, Steve <[email protected]> wrote:
> > When fetching the wget files and compiling it, I get the following
> warnings:
> [...]
> > Is it normal to have those "division by zero" errors and the "subscript
> out of range"?
> 
> Good you mention these. I checked my GerH sources as well to make sure
> I don't screw up the answer:
> 
> 
> The divisions by zero are 'by design'. I wouldn't call them 'normal'
> so I immediately recognized them, but they are a way to create 'NaN's
> which are useful to mark certain math operations as 'undoable' in the
> crm R-domain math context (square roots of negative values, that sort
> of stuff).
> 
Okay. I see.


> The 'subscript out of range' is definitely a bug as it has been
> corrected long ago in the GerH code: snippet follows:
> 
> ---
>     {
>         char vname[129];
>         strncpy(vname, &nametext[namestart],
>                 ((128 < namelen) ? 128 : namelen));
>         vname[128] = 0; /* [i_a] boundary bug */
>         fatalerror("You have blown the memory-storage gaskets while
> trying"
>                    "to store the ISOLATEd variable ", vname);
>         return 1;
>     }
> ---
> 
Your sources don't have that 'subscription out of range' errors. But your sources fail on my setup (while the wget version of CRM114 works):
----
crm114_osbf.h(160): error: expected a ")"
                                                  * unsigned int spectrum_start */);
                                                  ^

crm_vector_tokenize.c(401): warning #279: controlling expression is constant
          CRM_ASSERT(!"This should never happen in a properly coded CRM114...");
          ^

crm_vector_tokenize.c(410): warning #279: controlling expression is constant
          CRM_ASSERT(!"This should never happen in a properly coded CRM114...");
          ^

crm_vector_tokenize.c(417): warning #279: controlling expression is constant
          CRM_ASSERT(!"This should never happen in a properly coded CRM114...");
          ^

compilation aborted for crm_vector_tokenize.c (code 2)
----


> 
> I hope Bill will correct the latter in the official wget, please?
> 
The change looks like "low hanging fruits" to me. Can you change that Bill?

> 
> 
> -- 
> Met vriendelijke groeten / Best regards,
> 
> Ger Hobbelt
> 
Steve

> --------------------------------------------------
> web: http://www.hobbelt.com/
>  http://www.hebbut.net/
> mail: [email protected]
> mobile: +31-6-11 120 978
> --------------------------------------------------

-- 
GMX Kostenlose Spiele: Einfach online spielen und Spaß haben mit Pastry Passion!
http://games.entertainment.gmx.net/de/entertainment/games/free/puzzle/6169196

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/