Re: Case sensitivity in CLASSIFY and LEARN
Bill Yerazunis <[email protected]>
| Newsgroups | gmane.mail.spam.crm114 |
|---|---|
| Message-ID | <[email protected]> |
From: "Ger Hobbelt" <[email protected]> Actually, I say this is a bug in crm114 you've run into. <nitty gritty 'C' code detail mode on> The different behaviour with/without trap makes sense in a way, as the error was marked as trappable in the code, yet when caught by a trap that 'fatalerror5/fatalerror() call will 'return' so the script execution can continue and actually execute your trap handling script section -- where the next bit of code will exit crm114 ANYHOW, so no dice getting that trap section to actually run. And when you did NOT specify a trap, fatalerror() would already have 'exit()'ed the building, so you only see anything happening past that call when it IS trapped. Both ways, you're dead in the water. What's the bug then? Well, say fatalerror() found the 'trap' in your script and hence returns to caller so we can go on with our script (trap section), we STILL don't get a chance as right there in crm_set_temp_nvar() the code STILL exit()s the building, while it *should* have simply returned to caller. <nitty gritty 'C' code detail mode off> Meanwhile, this error IS 'trappable' (as it does not damage the system nor our state in unpredictable ways), just as that particular fatalerror() call would suggest (we have 'untrappableerror()' for those truely killing failures that are irrecoverable in any way), so the extra 'ha! you trapped me but, but nah nah, we exit crm114 right now anyhow' code bit has to go. Hmmm... yeah, I think you are right... maybe. The overflowing error is not retryable, but it is perhaps possible to maybe do something else. however, if this was a situation where you only had a couple of Kbytes left anyway, then there may not be enough space for the TRAP handler to run either. I would need to check the TRAP source code on this. Also, crm_expr_file_io.c should not ask for too many characters either. However, you can get to your patch in other ways than through input of a very large file. I'd put this in now, but my laptop is now deep in the throes of Memtest86. And it may need a reinstall. :( - Bill Yerazunis ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/