svn commit: r1935666 - in spamassassin/trunk/lib/Mail/SpamAssassin: . Plugin

[email protected] Fri, 26 Jun 2026 17:11:37 -0000
Newsgroups gmane.mail.spam.spamassassin.cvs
Message-ID <178249389763.1569685.12064547090603478608@svn03-he-fi>
Author: billcole
Date: Fri Jun 26 17:11:37 2026
New Revision: 1935666

Log:
fixed explcit 'return undef' in 3 places to quiet PerlCritic test.

Modified:
   spamassassin/trunk/lib/Mail/SpamAssassin/Message.pm
   spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/NeuralNetwork.pm

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Message.pm
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/Message.pm	Fri Jun 26 16:07:31 2026	(r1935665)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/Message.pm	Fri Jun 26 17:11:37 2026	(r1935666)
@@ -1266,7 +1266,7 @@ sub _find_part_by_type {
     return $n if $n->is_leaf() && $n->{'type'} eq $type;
     push @q, @{$n->{'body_parts'}} if !$n->is_leaf();
   }
-  return undef;
+  return;
 }
 
 ###########################################################################

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/NeuralNetwork.pm
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/NeuralNetwork.pm	Fri Jun 26 16:07:31 2026	(r1935665)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/NeuralNetwork.pm	Fri Jun 26 17:11:37 2026	(r1935666)
@@ -2108,7 +2108,7 @@ sub _extract_features_from_message {
 # survives a round-trip through a SQL keyword index.
 sub _sanitize_token {
   my ($t) = @_;
-  return undef unless defined $t;
+  return unless defined $t;
   if (!utf8::is_utf8($t) && $t =~ /[^\x00-\x7f]/) {
     require Encode;
     $t = Encode::decode('UTF-8', $t, Encode::FB_DEFAULT());
@@ -2335,7 +2335,7 @@ sub _save_model_vocab_to_sql {
 
 sub _load_model_vocab_from_sql {
   my ($self, $username) = @_;
-  return undef unless $self->{dbh};
+  return unless $self->{dbh};
 
   $username //= $self->{main}->{username};