[Bug 8331] Redis.pm: separate read/write server handling

[email protected]
Newsgroups gmane.mail.spam.spamassassin.devel
Message-ID <[email protected]/SpamAssassin/>
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8331

--- Comment #7 from Giovanni Bechis <[email protected]> ---
Few comments to the code:
- private subs should start with a "_", 'sub connect_read' should become 'sub
_connect_read'
- regexps that uses variables controlled by the user like '$msgid =~
s/^$self->{key_prefix}s://;', must be "compiled" using 'compile_regexp' sub
from Mail::SpamAssassin::Util.
An example of this code is in Mail::SpamAssassin::Plugin::OLEVBMacro

-- 
You are receiving this mail because:
You are the assignee for the bug.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.