[Bug 8340] DMARC avoidance

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8340

Kent Oyer <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #7 from Kent Oyer <[email protected]> ---
First minor nitpick: Your regex has '\s' twice.

Second minor nitpick: Your patch seems to fix the DMARC issue however so does
this much simpler patch:

@@ -2640,10 +2640,6 @@
     if (defined $2) {
       # Remove comments (no nested support here)
       $address =~ s/\((?:|(?:[^()\\]++|\\.)*+)\)//gs;
-      # Validate as somewhat email looking
-      if ($address !~ /^$header_address_mailre$/) {
-        $address = undef;
-      }
     }


In other words, don't set $address to undef if it doesn't validate. By removing
invalid chars you are preventing other tests from checking for these invalid
chars. Your patch converts "no reply" to "noreply" but if I have this rule:

header   RULE_NAME   From:addr =~ /no reply/

it will not fire.

-- 
You are receiving this mail because:
You are the assignee for the bug.