Re: [PR] do not match on 123-123_1234 phone numbers [spa massassin]

fkoyer commented on PR #20:
URL: https://github.com/apache/spamassassin/pull/20#issuecomment-3448742042

   __MXG_PHONE_OBFU is a subtest rule so it doesn't contribute to the score at all unless it's used in a meta rule. I would not suggest using it to block messages by itself. There will be false positives due to typos but also if you are using the ExtractText plugin to extract text from images there will be false positives because the OCR software sometimes incorrectly recognizes a zero as the letter O or a one as the letter I. 
   
   Regardless, I can't accept your change because it fires on many legitimate numbers including:
   
   * (123) 123 1234
   * 123.123.1234
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]