Re: Patches from Robert Millan

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Magnus Holmgren wrote:
> Any comments or objections to these patches?
> http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;att=1;bug=430508

Thanks for your patch!

Robert Millan wrote in bugs.debian.org #430508:
> spfquery segfaults when passing it a -guess argument:
>
>   $ spfquery -ip 1.2.3.4 -sender [email protected] -helo foo -guess blah
>
> This is caused by spf_response_2mx being a null pointer in
> APPEND_RESULT(SPF_response_result(spf_response_2mx));
>
> I *think* that usage of this variable is all wrong in this routine,
> since we're checking for fallback spf record not 2nd rcpt mx.  See
> attached patch for a proposed fix.

I think the use of the "spf_response_2mx" variable instead of an 
additional, separate "spf_response_fallback" for the fallback branch in 
spfquery.c was laziness on the spfquery author's part.  However, the 
initialization of "spf_response" instead of "spf_response_2mx" was clearly 
erroneous.  Overall, I think Robert's patch for bdo #430508 is sound.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGl/pRwL7PKlBZWjsRAnpuAKC7QdzqLZaA/anMRjEDWU+DywcOPQCdGUpo
H01G+BtYJPDSJGo1tNhA0rg=
=xWK1
-----END PGP SIGNATURE-----

-------------------------------------------
-----------------------------------------------------------------------
To unsubscribe, change your address, or temporarily deactivate your
subscription,
please go to http://v2.listbox.com/member/?member_id=6959932&id_secret=21958236-a4a348
Powered by Listbox: http://www.listbox.com