Re: Re: Upcoming new test-suite release

"Stuart D. Gathman" <[email protected]> Fri, 7 Dec 2007 18:29:07 -0500 (EST)
Newsgroups gmane.mail.spam.spf.devel
Message-ID <[email protected]>
On Fri, 7 Dec 2007, Julian Mehnle wrote:

> What about removing my redundant test in favor of an improved description 
> for the existing "invalid-domain-empty-label" test?  (See attached diff.)

The "description" field is the "short" description.  It is supposed to be a one
line (or maybe several when quoting ABNF from the RFC) summary.  The
"comment" field is the multiline explanation.  You are welcome
to make the description + comment better, but please keep the
one-line summary + explanatory paragraph format.

> The "invalid-domain-long" test's description has the same problem.  
> However, I did not want to edit that one before having discussed the 
> following:  This test tests the "overlong label" case.  But why is it 
> using macro expansion to that end?  It could just as well say
> "a:<64chars>.bar".  That would allow to simplify the description even 
> further.

See toolonglabel.  You need to test both before and after macro expansion.
The "spec" field is very informative for why tests are there.  The
toolonglabel test is for 4.3/1.  The invalid-domain-long test is for
8.1/2 and 5/10.

-- 
	      Stuart D. Gathman <[email protected]>
    Business Management Systems Inc.  Phone: 703 591-0911 Fax: 703 591-6154
"Confutatis maledictis, flammis acribus addictis" - background song for
a Microsoft sponsored "Where do you want to go from here?" commercial.

-------------------------------------------
Sender Policy Framework: http://www.openspf.org
Archives: http://v2.listbox.com/member/archive/1007/=now
RSS Feed: http://v2.listbox.com/member/archive/rss/1007/
Modify Your Subscription: http://v2.listbox.com/member/?member_id=6959932&id_secret=73869839-30c974
Powered by Listbox: http://www.listbox.com