Re: New version of spfmilter with libspf2-1.2.9

"G.W. Haywood" <[email protected]> Tue, 16 Dec 2008 10:06:23 +0000 (GMT)
Newsgroups gmane.mail.spam.spf.devel
Message-ID <[email protected]>
Hi Shevek,

On Mon, 15 Dec 2008, Shevek wrote:

> On Sun, 2008-12-14 at 21:45 +0000, G.W. Haywood wrote:
> >
> > Memory usage graph for spfmilter using libspf2-1.2.9:
> > ...
> > Does anyone have any comments to make on the memory consumption?
>
> Hrm. At a guess, something's losing a chunk, but neither I nor our
> earlier coverity scan could immediately see it. There is always the
> possibility that it's just filling in the DNS cache, and that the jumps
> in usage are just finding a free bucket in the open hash table.

I was hoping you might have suggestions of that sort, that's why I
posted before investigating further.

> It's not climbing drastically. Have you run the system under
> valgrind? Do you know how many messages actually hit the milter?

That's right, it's perfectly manageable on this fairly quiet system.
No, I haven't run it under valgrind, nor have I done any investigation
other than looking at the graph and wondering. :)  Approximately 2,000
messages actually hit the milter in the period covered by the graph.

> I would be tempted, at this stage, to fold spfmilter into the libspf2
> tree, for ease of distribution and installation, but I am not keen to
> maintain it. Would you be interested in being a co-maintainer in
> subversion if I were to do so?

That sounds fine to me, I'll be happy to do that, and I'm happy to look
deeper into this memory issue too.  Watch this space (but don't hold
your breath... :)

--

73,
Ged.