Re: SPF vulnerability
karan pott <[email protected]> Tue, 21 Apr 2009 16:14:51 +0530 (IST)
| Newsgroups | gmane.mail.spam.spf.devel |
|---|---|
| Message-ID | <[email protected]> |
--0-239921660-1240310691=:30577 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Shevek, I have made all the necessary changes to libspf2 (1.2.9) to port it to Wind= ows. It has been tested on Windows also. I like to submit my changes to be = included as part of the official download. Can you please let me know I can= go about this? Thanks, Karan ________________________________ From: karan pott <[email protected]> To: Shevek <[email protected]>; [email protected] Sent: Friday, 17 April, 2009 9:18:40 AM Subject: Re: [spf-devel] SPF vulnerability Thanks Shevek, Here is the modified file. the change is at line 350, Please= let me know if you have any comments. Thanks and Regards, Karan. ________________________________ From: Shevek <[email protected]> To: [email protected] Cc: karan pott <[email protected]> Sent: Thursday, 16 April, 2009 4:10:54 PM Subject: Re: [spf-devel] SPF vulnerability On Fri, 2009-04-10 at 12:04 +0530, karan pott wrote: > Hi Shevek, >=20 > I have spent a bit of effort to make libspf2 1.2.9 to be compilable on > Windows with Visual Studio 2005. However, while testing I figured out > that (libspf2-1.2.9\src\libspf2\spf_server.c : 350) had the statement > which made SPF_dns_lookup fail with DNSTIMEOUT rather that the return > codes being checked for. >=20 > But when I modified the code to (rr_type =3D ns_t_txt), it started > working okay. I would like to confirm that, is there something missing > from the original code or my change is okay. >=20 > Another important thing I like to know is that once I am done with my > porting effort, I would like to submit my code. Can you please guide > how and what the procedure is and How I can get my source code > reviewed. Sure, just email me a patch, and if it looks sane I'll throw it in. I suspect it's very likely to look sane, since you obviously know what you're talking about. S. ________________________________ Add more friends to your messenger and enjoy! Invite them now. Now surf faster and smarter ! Check out the new Firefox 3 - Yahoo! Ed= ition http://downloads.yahoo.com/in/firefox/ ------------------------------------------- Sender Policy Framework: http://www.openspf.org Modify Your Subscription: http://www.listbox.com/member/ Archives: https://www.listbox.com/member/archive/1007/=3Dnow RSS Feed: https://www.listbox.com/member/archive/rss/1007/ Powered by Listbox: http://www.listbox.com --0-239921660-1240310691=:30577 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><head><style type=3D"text/css"><!-- DIV {margin:0px;} --></style></he= ad><body><div style=3D"font-family:times new roman,new york,times,serif;fon= t-size:12pt"><div>Hi Shevek,<br><br>I have made all the necessary changes t= o libspf2 (1.2.9) to port it to Windows. It has been tested on Windows also= . I like to submit my changes to be included as part of the official downlo= ad. Can you please let me know I can go about this?<br><br>Thanks,<br>Karan= <br></div><div style=3D"font-family: times new roman,new york,times,serif; = font-size: 12pt;"><br><div style=3D"font-family: times new roman,new york,t= imes,serif; font-size: 12pt;"><font size=3D"2" face=3D"Tahoma"><hr size=3D"= 1"><b><span style=3D"font-weight: bold;">From:</span></b> karan pott <op= [email protected]><br><b><span style=3D"font-weight: bold;">To:</= span></b> Shevek <[email protected]>; [email protected]<br><b><s= pan style=3D"font-weight: bold;">Sent:</span></b> Friday, 17 April, 2009 9:= 18:40 AM<br><b><span style=3D"font-weight: bold;">Subject:</span></b> Re: [spf-d= evel] SPF vulnerability<br></font><br><div style=3D"font-family: times new = roman,new york,times,serif; font-size: 12pt;"><div>Thanks Shevek, Here is t= he modified file. the change is at line 350, Please let me know if you have= any comments.<br><br>Thanks and Regards,<br>Karan.</div><div style=3D"font= -family: times new roman,new york,times,serif; font-size: 12pt;"><br><div s= tyle=3D"font-family: arial,helvetica,sans-serif; font-size: 13px;"><font si= ze=3D"2" face=3D"Tahoma"><hr size=3D"1"><b><span style=3D"font-weight: bold= ;">From:</span></b> Shevek <[email protected]><br><b><span style=3D"fon= t-weight: bold;">To:</span></b> [email protected]<br><b><span style= =3D"font-weight: bold;">Cc:</span></b> karan pott <open_mind_core@yahoo.= co.in><br><b><span style=3D"font-weight: bold;">Sent:</span></b> Thursda= y, 16 April, 2009 4:10:54 PM<br><b><span style=3D"font-weight: bold;">Subje= ct:</span></b> Re: [spf-devel] SPF vulnerability<br></font><br>On Fri, 2009-04-10 at 12:04 +0530, karan pott = wrote:<br>> Hi Shevek,<br>> <br>> I have spent a bit of effort to = make libspf2 1.2.9 to be compilable on<br>> Windows with Visual Studio 2= 005. However, while testing I figured out<br>> that (libspf2-1.2.9\src\l= ibspf2\spf_server.c : 350) had the statement<br>> which made SPF_dns_loo= kup fail with DNSTIMEOUT rather that the return<br>> codes being checked= for.<br>> <br>> But when I modified the code to (rr_type =3D ns_t_tx= t), it started<br>> working okay. I would like to confirm that, is there= something missing<br>> from the original code or my change is okay.<br>= > <br>> Another important thing I like to know is that once I am done= with my<br>> porting effort, I would like to submit my code. Can you pl= ease guide<br>> how and what the procedure is and How I can get my sourc= e code<br>> reviewed.<br><br>Sure, just email me a patch, and if it looks sane I'll throw it in. I<br>suspect it's very likely to look sane, s= ince you obviously know what<br>you're talking about.<br><br>S.<br><br><br>= </div></div></div><br> <hr size=3D"1"> Add more friends to your messenger and enjoy! <a rel= =3D"nofollow" target=3D"_blank" href=3D"http://in.rd.yahoo.com/tagline_mess= enger_6/*http://messenger.yahoo.com/invite/"> Invite them now.</a></div></d= iv></div><br> <!--6--><hr size=3D1></hr> Own a website.Get an unlimited package.Pay= next to nothing.*<a href=3D"http://in.rd.yahoo.com/tagline_ysb_website/*ht= tp://in.business.yahoo.com/"> Click here!.</a><div style=3D"padding:0 4px 4= px 4px;background-color:#fff;clear:both" bgcolor=3D"#ffffff"> <hr> <p>Sender Policy Framework: <a href=3D"http://www.openspf.org">http://www.o= penspf.org</a><br>=0D Modify Your Subscription: <a href=3D"http://www.listbox.com/member/">http:/= /www.listbox.com/member/</a></p> <table border=3D"0" cellspacing=3D"0" cellpadding=3D"0" width=3D"100%" styl= e=3D"background-color:#fff" bgcolor=3D"#ffffff"> <tr> <td padding=3D"4px"> <font color=3D"black" size=3D"1" face=3D"helvetica, sans-serif;"> <a style=3D"text-decoration:none;color:#669933;border-bottom: 1px sol= id #444444" href=3D"https://www.listbox.com/member/archive/1007/=3Dnow" title=3D"Go to = archives for spf-devel">Archives</a> <a border=3D"0" style=3D"text-decoration:none;color:#669933" href=3D"https:= //www.listbox.com/member/archive/rss/1007/" title=3D"RSS feed for spf-devel= "><img border=3D0 src=3D"https://www.listbox.com/images/feed-icon-10x10.jpg= "></a> <td valign=3D"top" align=3D"right"><a style=3D"border-bottom:none;" href=3D= "http://www.listbox.com"> <img src=3D"https://www.listbox.com/images/listbox-logo-small.jpg" title=3D"Powered by Listbox" border=3D"0" /></a></td> </font> </td> </tr> </table> </div> </body></html>= --0-239921660-1240310691=:30577--