CVS: tmda ChangeLog,1.110,1.111 THANKS,1.61,1.62

"Jason R. Mastaler" <[email protected]>
Newsgroups gmane.mail.spam.tmda.cvs
Message-ID <[email protected]>
Update of /cvsroot/tmda/tmda
In directory sc8-pr-cvs1:/tmp/cvs-serv22982

Modified Files:
	ChangeLog THANKS 
Log Message:
Bugfix.  There was order dependance in the option processing of
tmda-address. e.g,:

$ tmda-address -d 1d -a [email protected]
[email protected]
  
$ tmda-address -a [email protected] -d 1d
[email protected]
  
The same behavior also applies if you use -c and a config file that
changes the relevant config options.  

The problem is caused by the behavior of Python's getopt, which stops
processing options when it reaches a non-option argument (unlike GNU
getopt).  Since -d doesn't require an argument, the "1d" in the first
example below is a non-option argument, which stops the option
processing, leaving '1d', '-a', and '[email protected]' in args.  Since
the -k and -s options require an argument, they don't exhibit the same
behavior.

Change summary:
- move getopt invocation to a subroutine
- do initial getopt using new subroutine with sys.argv[1:]
- add an outer loop to redo the opts processing while there are items
  left in the opts list
- change opts processing to use a copy of opts, so that opts list can
  be changed in the loop
- add code to remove opts from the list after they're processed
- add code to look for more opts in args list after -d is handled
  - remove args that don't start with a '-'
  - send remaining args to new subroutine, appending any detected
    options to opts list

Thanks to Ed Blackman for the fix.


Index: ChangeLog
===================================================================
RCS file: /cvsroot/tmda/tmda/ChangeLog,v
retrieving revision 1.110
retrieving revision 1.111
diff -u -r1.110 -r1.111
--- ChangeLog	1 May 2003 19:00:06 -0000	1.110
+++ ChangeLog	15 May 2003 21:11:34 -0000	1.111
@@ -1,3 +1,7 @@
+2003-05-15  Jason R. Mastaler  <[email protected]>
+
+	* THANKS (Contributions): Add Ed Blackman.
+
 2003-05-01  Jason R. Mastaler  <[email protected]>
 
 	* TMDA 0.77 is released.

Index: THANKS
===================================================================
RCS file: /cvsroot/tmda/tmda/THANKS,v
retrieving revision 1.61
retrieving revision 1.62
diff -u -r1.61 -r1.62
--- THANKS	26 Apr 2003 23:14:53 -0000	1.61
+++ THANKS	15 May 2003 21:11:34 -0000	1.62
@@ -23,6 +23,8 @@
     * Ron Bickers -- countless suggestions, bugfixes, documentation
       additions, and code patches (too many to list).
 
+    * Ed Blackman -- bugfixes.
+
     * Francisco Sam Castillo -- QAdmin-TMDA web management utility.
 
     * Charles Cazabon -- Maildir and mbox delivery code from getmail.

_______________________________________
tmda-cvs mailing list
http://tmda.net/lists/listinfo/tmda-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.