Re: Bugs in tmda-ofmipd?

Stephen Warren <[email protected]> writes:

> What I'd like to do is apply a patch to tmda-ofmipd that catches all
> exceptions in process_message and logs them to the debug log, then
> re-raises the exception to be handled in the existing fashion.
>
> With this patch, the behaviour of tmda-ofmipd should end up being the
> same - all exceptions are thrown through to whatever existing handler
> exists.
>
> However, if we then log all exceptions ourselves explicitly, we should
> be able to find those exceptions that are not being handled by the
> Python core SMTP module, and try to work out why these cause immediate
> sessions drops rather than SMTP error codes.
>
> See that attached proposed patch. I have tested this by attempting to
> send email to an unknown local user; in this case, for me, the exception
> is logged to tmda-ofmipd's STDERR (I have the -d flag enabled) and is
> also passed through to Thunderbird via an SMTP error message, and
> displayed on the client UI.

Looks good to me.  Lock and load.

BTW, you should probably get in the habit of testing tmda-ofmipd with
an additional, non-Mozilla based MUA.  Though it's far from
unit-testing, it sure won't hurt.

BTW(2), further discussion of these gritty details should probably be
done on -workers in a new thread.

BTW(3), thanks for looking into this.