Re: tmda-ofmipd: the dreaded TypeError: Expected list, got <type 'str'>

Stephen Warren wrote:
> Dave Steinberg wrote:
>> Stephen Warren wrote:
>>> The MUA is Thunderbird, right?
>> GNUS actually, but the actual delivery is done by postfix.
> 
> Huh. So it's GNUs ---> (via SMTP) ---> tmda-ofmipd --> postfix then, 
> just like normal tmda-ofmipd usage?

GNUs (as I understand it) is a non-smtp MUA.  So it goes like this:

GNUs (via sendmail binary) -> postfix -> tmda-ofmipd

Everything before tmda-ofmipd happens on the customer's home computer.

> Sounds like there are now two MUAs that have the same 
> don't-throw-error-on-dropped-SMTP-connection bug then...

In this case it'd be postfix, which I am no expert in.  He did provide 
me with logs of the transactions, so I can supply them if they're 
helpful.  Suffice to say postfix thought the messages were successfully 
received by tmda-ofmipd.

It seems that the error occurred during delivery-time, after the smtp 
transaction.  I think I may have cropped a line before in my log 
snippit.  Here's what I think is the full set of logs for a particular 
connection:

Incoming connection from: ('127.0.0.1', 11595) 

Incoming connection to: ('127.0.0.1', 7025)
Trying authprog method
Auth:  succeeded for user 'REDACTED'
===> MAIL FROM:<REDACTED> AUTH=<>
sender: REDACTED AUTH=<
===> RCPT TO:<REDACTED2>
recips: ['REDACTED2']
vuser homedir: "/home/vpopmail/domains/1/REDACTED"
Error: failure delivering message to command 
"['/usr/local/bin/tmda-inject', 'REDACTED2']" (comman
d "['/usr/local/bin/tmda-inject', 'REDACTED2']" exited 1  (Traceback 
(most recent call last):
File "/usr/local/bin/tmda-inject", line 116, in ?
orig_msgout_as_string = Util.msg_as_string(msgout) 

File "./TMDA/Util.py", line 552, in msg_as_string
File "./TMDA/pythonlib/email/generator.py", line 84, in flatten
File "./TMDA/pythonlib/email/generator.py", line 109, in _write
File "./TMDA/pythonlib/email/generator.py", line 135, in _dispatch
File "./TMDA/pythonlib/email/generator.py", line 266, in _handle_message
File "./TMDA/pythonlib/email/message.py", line 185, in get_payload
TypeError: Expected list, got <type 'str'>))

Sorry if I misled on this originally, clearly not my intention.  Perhaps 
I have placed the blame on the wrong program - it'd be tmda-inject that 
should sit in the corner!

PS - I'll try your patch for tmda-ofmipd in the morning.  Any chance it 
could make its way into the trunk?

Thanks for your time,
-- 
Dave Steinberg
http://www.geekisp.com/
http://www.steinbergcomputing.com/