Bug in squirrelmail-20111024_0200-SVN, addrbook_search_html.php

Squirrelmail version: 1.5.2 (20111024_0200-SVN)

Every plugin installed:

$plugins[] = 'cmumenuline'; (written here)
$plugins[] = 'compose_extras';
$plugins[] = 'useracl';
$plugins[] = 'check_quota';
$plugins[] = 'add_address';
$plugins[] = 'cmuldapdefault'; (written here)
$plugins[] = 'ldapquery';
$plugins[] = 'message_details';

PHP version: 5.2.6

Web server: Apache 1.3.39

IMAP server: Cyrus 2.4.x

SMTP server: sendmail 8.14.4

OS: Linux, based on fc3

Details about the bug:

 From the message view, if you click the "Forward" button, then click 
the "Addresses" button to add an address, the body of the message will 
corrupt the addressbook view due to the "body" hidden field not being 
escaped.

The following patch resolves this issue:

--- src/addrbook_search_html.php.orig   2011-10-24 13:27:42.000000000 -0400
+++ src/addrbook_search_html.php        2011-10-24 13:35:13.000000000 -0400
@@ -47,9 +47,9 @@

  //FIXME Do not echo HTML from the core.  This file already uses 
templates mostly, so why are we echoing here at all?!?
     if (substr($body, 0, 1) == "\r") {
-       echo addHidden('body', "\n".$body);
+       echo addHidden('body', "\n".htmlspecialchars($body));
     } else {
-       echo addHidden('body', $body);
+       echo addHidden('body', htmlspecialchars($body));
     }

     if (is_object($composeMessage) && $composeMessage->entities)

------------------------------------------------------------------------------
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn 
about Cisco certifications, training, and career opportunities. 
http://p.sf.net/sfu/cisco-dev2dev
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: [email protected]
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel