Re: Changing STABLE DOCTYPE?
"Michael A. Puls II" <[email protected]> Wed, 04 Jan 2012 04:04:51 -0500
| Newsgroups | gmane.mail.squirrelmail.devel |
|---|---|
| Message-ID | <op.v7jx6dfb1ejg13@vertiform346> |
On Tue, 03 Jan 2012 14:09:39 -0500, Paul Lesniewski <[email protected]> wrote: >>>>> I've been patching Squirrelmail for a long time now to make it run in >>>>> standards mode to fix things for Opera. I think it'd be great if >>>>> SquirrelMail did this by default. >>>> >>>> I'm going to propose a configuration setting so those who want to can >>>> change to standards mode. Please try the attached patch (against >>>> version 1.4.23-svn) and let me know if there are any problems. >> >> I tested. The patch works fine and makes the option available when >> configuring. Setting it to true makes the pages have: >> >> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" >> "http://www.w3.org/TR/html4/loose.dtd"> >> >> , which puts the pages in standards mode, which also avoids the Opera >> quirks >> mode font-size bug. I also didn't notice any issues with the display of >> messages or preference pages or message detail and message header >> plug-in >> pages etc. >> >> However, the transitional doctype (with the loose dtd URI specified) >> only >> triggers "almost standards mode" (see >> <http://hsivonen.iki.fi/doctype/>). A >> regular HTML 4.01 doctype with the strict dtd URI should trigger full >> standards mode. But, so will "<!DOCTYPE html>". As mentioned on the >> page, >> the main difference between standards mode and almost standards mode is >> the >> handling of images and alignment. If it's not a problem, it'd be best to >> shoot for full standards mode (or allow the choice between quirks, >> almost >> standards and standards modes). > > I suppose you're right; since SquirrelMail doesn't use any sliced > images, I didn't give much credence to the difference between > loose/strict. I'm changing the patch to allow for quirks, almost > standards and standards. I don't know as it makes much sense to allow > HTML5, but that could be added more easily to this scheme as well. O.K. > Please revert the last patch and try the one attached to this message. Patch works fine. All 3 options work fine and produce the correct doctype. And, if you use something other than "quirks", "standards" or "almost" like "zipzambam", it defaults to quirks, which makes sense. I did find a few super-minor issues though: * With "almost" and "standards" mode, on the "options -> display preferences" page, the checkboxes at the bottom are not aligned as intended. They're shifted to the right a bit. * With "standards" mode, on the message page where you have "message list", "Unread", "Delete", "Previous", "Next" etc. links, the container those links are in becomes a tad bit taller. You can tell because the gray background gets a tad bit taller. * The day number links in the cells for the calendar plug-in are shifted down a few pixels in "standards" mode. Nothing major. -- Michael ------------------------------------------------------------------------------ Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex infrastructure or vast IT resources to deliver seamless, secure access to virtual desktops. With this all-in-one solution, easily deploy virtual desktops for less than the cost of PCs and save 60% on VDI infrastructure costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox ----- squirrelmail-devel mailing list Posting guidelines: http://squirrelmail.org/postingguidelines List address: [email protected] List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel