imapproxy Patches
Richard Laager <[email protected]> Wed, 23 Nov 2016 18:04:17 -0600
| Newsgroups | gmane.mail.squirrelmail.devel |
|---|---|
| Message-ID | <[email protected]> |
I see you have recently accepted a round of imapproxy patches. I would like to bring the following patches to your attention. So far, these have only passed the "it compiles" test. I'll be testing all this code in production in a few days (after the Thanksgiving holiday). The EGD conditional is backwards: https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/fix-egd-ifdef.patch This fixes a compiler warning about not checking the return value from dup(): https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/check-dup-return-value.patch This fixes some missing function definitions: https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/fix-missing-definitions.patch This fixes some warnings about size_t printf formatters. Note, I'm not sure how portable the "z" modifer is: https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/fix-size_t-formatters.patch This uses socklen_t instead of int to fix some type mismatch warnings: https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/fix-socklen_t-types.patch This fixes signedness warnings: https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/fix-ssl-types.patch This fixes compiling on OpenSSL 1.1: https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/openssl-1.1.patch Are these variables used? If not, they should be removed rather than #ifdef 0'ed as this patch does: https://github.com/rlaager/imapproxy-pkg/blob/master/debian/patches/remove-unused-variables.patch -- Richard ------------------------------------------------------------------------------ ----- squirrelmail-devel mailing list Posting guidelines: http://squirrelmail.org/postingguidelines List address: [email protected] List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel