Merging Changes from 1.4.15 and MagicMail's version..
Michael Peddemors <[email protected]>
| Newsgroups | gmane.mail.squirrelmail.devel |
|---|---|
| Organization | LinuxMagic Inc. |
| Message-ID | <[email protected]> |
As time permits, we are going to attempt to see if we can get our customized
changes recorded, and possibly merged with the SM branch. One of the things
discussed recently is the look and feel aspects of SM, and in order to make
our versions have the snappy look some code changes had to be made.
Some of these changes might also make it easier for Vendors who sell
customized skins etc for SM to more easily deploy their versions, and
possibly we might be able to get our graphics team to contribute a new skin.
Expect a few posts to the list about our changes, and some requests..
Most of these items might need to be discussed on the dev list for their
merits for inclusion..
One main one is the way image paths are handled, and we have set a new
standard for this inhouse, and maybe this method might be worth considering..
But the main function that is required is get_img_path() instead of calling
hard coded values for the locations..
We inserted into functions/html.php..
/**
- * Generate image source location strings
- *
- * @param string $img_name
- * @return string path string ie "SM_PATH/images/$img_name"
- */
-
-function get_img_path($img_name) {
-
- // Validation??
- // Hate that this is done everywhere..
- define('SM_PATH', '../');
- require_once(SM_PATH . 'config/config.php');
-
- // Need to check if a config item exists that specifies
- // an alternate images directory location.
- global $custom_img_path;
-
- if ( isset( $custom_img_path )) {
- // Put trailing slash if they didn't in the config.php
- if (!(preg_match('/\/$/',$custom_img_path))) {
- $custom_img_path .= '/';
- }
- // Need to see if the image exists at that location
- if (file_exists(SM_PATH . $custom_img_path . $img_name)) {
- return SM_PATH . $custom_img_path . $img_name;
- } else {
- return SM_PATH . 'images/' . $img_name;
- }
- } else {
- return SM_PATH . 'images/' . $img_name;
- }
-}
--
--
"Catch the Magic of Linux..."
------------------------------------------------------------------------
Michael Peddemors - President/CEO - LinuxMagic
Products, Services, Support and Development
Visit us at http://www.linuxmagic.com
------------------------------------------------------------------------
A Wizard IT Company - For More Info http://www.wizard.ca
"LinuxMagic" is a Registered TradeMark of Wizard Tower TechnoServices Ltd.
------------------------------------------------------------------------
604-589-0037 Beautiful British Columbia, Canada
This email and any electronic data contained are confidential and intended
solely for the use of the individual or entity to which they are addressed.
Please note that any views or opinions presented in this email are solely
those of the author and are not intended to represent those of the company.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: [email protected]
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel